[server] Set table_id on prepareLakeTableSnapshot error response#3550
Merged
luoyuxia merged 1 commit intoJul 1, 2026
Merged
Conversation
fresh-borzoni
force-pushed
the
fix-prepare-lake-snapshot-error-response
branch
from
c172f80 to
6a81e3c
Compare
2 tasks
luoyuxia
approved these changes
Jul 1, 2026
luoyuxia
left a comment
luoyuxia
left a comment
Contributor
There was a problem hiding this comment.
@fresh-borzoni Thanks. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3551
When anything in the per-table loop of
CoordinatorService.prepareLakeTableSnapshotfails, the catch seterror_code/error_messagebut nottable_id, and didn't log the exception.The tiering committer reads
table_idbefore checking the error, so it crashed with Field 'table_id' is not set` andmasks the real failure and no trace in logs
This sets
table_idon the error response and logs the exception, so the real error surfacesboth to the client and in the coordinator logs.