[FLINK-37288] Add Google Cloud Spanner dialect and catalog #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
laughingman7743
changed the title
laughingman7743
commented
Feb 9, 2025
Comment on lines
-133
to
-138
| this.connectionProperties = Preconditions.checkNotNull(connectionProperties); | ||
| checkArgument( | ||
| !StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(USER_KEY))); | ||
| checkArgument( | ||
| !StringUtils.isNullOrWhitespaceOnly( | ||
| connectionProperties.getProperty(PASSWORD_KEY))); |
There was a problem hiding this comment.
Spanner does not use password authentication.
laughingman7743
commented
Feb 9, 2025
Comment on lines
-579
to
-588
| /** | ||
| * URL has to be without database, like "jdbc:dialect://localhost:1234/" or | ||
| * "jdbc:dialect://localhost:1234" rather than "jdbc:dialect://localhost:1234/db". | ||
| */ | ||
| protected static void validateJdbcUrl(String url) { | ||
| String[] parts = url.trim().split("\\/+"); | ||
|
|
||
| checkArgument(parts.length == 2); | ||
| } | ||
|
|
There was a problem hiding this comment.
In the case of Spanner, the URL is as follows, so I have deleted this validation.
jdbc:cloudspanner://hostname/projects/gcp_project_id/instances/instance_id/databases/database_id
laughingman7743
commented
Feb 9, 2025
|
|
||
| /** Test for {@link AbstractJdbcCatalog}. */ | ||
| class AbstractJdbcCatalogTest { |
There was a problem hiding this comment.
This class is no longer needed because URL validation has been removed.
laughingman7743
commented
Feb 9, 2025
| @@ -120,7 +122,7 @@ public int[] getTableTypes() { | |||
| .toArray(); | |||
| } | |||
|
|
|||
| public Schema getTableSchema() { | |||
| public Schema getTableSchema(String pkConstraintName) { | |||
There was a problem hiding this comment.
In the case of Spanner, the contract name of the primary key is different, so it is possible to specify the contract name of the primary key.
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
8 times, most recently
from
c7f0a5a to
3a73e0b
Compare
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
from
3a73e0b to
be60494
Compare
|
I have applied code formatting using Spotless and updated the documentation. It is ready for review. |
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
from
be60494 to
e4559c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-37288