[FLINK-36682][mysql][mongodb] Add scan.chunk.assign.strategy to avoid OOM exception. #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol whether assign evenly splits in reverse order to avoid OOM exception.
yuxiqian
reviewed
Nov 9, 2024
Comment on lines
162
to
175
| public static final ConfigOption<Boolean> SCAN_FLATTEN_NESTED_COLUMNS_ENABLED = | ||
| ConfigOptions.key("scan.flatten-nested-columns.enabled") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription( | ||
| "Optional flag to recursively flatten the Bson field into columns." | ||
| + "For a better understanding, the name of the flattened column will be composed of the path to get the column. " | ||
| + "For example, the field `col` in the Bson document {\"nested\": {\"col\": true}} is `nested.col` in the flattened schema. "); | ||
|
|
||
| public static final ConfigOption<Boolean> SCAN_PRIMITIVE_AS_STRING = | ||
| ConfigOptions.key("scan.primitive-as-string") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription("Optional flag to infer primitive types as string type."); |
…ol whether assign evenly splits in reverse order to avoid OOM exception.
| } | ||
| return SplitVectorSplitStrategy.INSTANCE.split(splitContext); | ||
| snapshotSplits.addAll(SplitVectorSplitStrategy.INSTANCE.split(splitContext)); |
There was a problem hiding this comment.
Seems it will split repeatly here.
| import org.apache.flink.cdc.connectors.base.source.meta.split.SnapshotSplit; | ||
|
|
||
| /** Strategy for {@link MongoDBChunkSplitter} to assign {@link SnapshotSplit}. */ | ||
| public enum AssignStrategy { |
There was a problem hiding this comment.
Could we move this class to flink-cdc-base module, and reuse it in mysql/mongo source module?
| @@ -125,6 +129,9 @@ public class MongoDBTableFactoryTest { | |||
| private static final boolean SCAN_NEWLY_ADDED_TABLE_ENABLED_DEFAULT = | |||
| SCAN_NEWLY_ADDED_TABLE_ENABLED.defaultValue(); | |||
|
|
|||
| private static final AssignStrategy SCAN_CHUNK_ASSIGN_STRATEGY_DEFAULT = | |||
There was a problem hiding this comment.
Could we add test in MongoDBConnectorITCase for DESCENDING_ORDER AssignStrategy? This can check the result correctness for the new assign strategy.
|
@lvyanquan Thanks for your contribution. I left some comments here. |
|
kindly ping @lvyanquan |
|
Closed as there is a better solution in #3856. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new config option scan.chunk.assign.strategy to control the order of split assignment.