Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Oct 24, 2025

What is the purpose of the change?

Upgrade HashedWheelTimer content based on latest Netty's HashedWheelTimer: remove all sun.misc.Unsafe relative codes since such codes could not be compiled with JDK17+ no matter adding --add-opens java.base/sun.misc=ALL-UNNAMED to the mvn command argline or not.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 70.10309% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.76%. Comparing base (0286216) to head (af16f88).
⚠️ Report is 4 commits behind head on 3.3.

Files with missing lines Patch % Lines
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 70.10% 21 Missing and 8 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15739      +/-   ##
============================================
- Coverage     60.67%   58.76%   -1.91%     
+ Complexity    10157       15   -10142     
============================================
  Files          1924     1938      +14     
  Lines         87086    88660    +1574     
  Branches      13115    13391     +276     
============================================
- Hits          52839    52104     -735     
- Misses        28759    30907    +2148     
- Partials       5488     5649     +161     
Flag Coverage Δ
samples-tests-java21 ?
samples-tests-java8 ?
unit-tests-java11 59.01% <70.10%> (+0.01%) ⬆️
unit-tests-java17 58.52% <70.10%> (-0.24%) ⬇️
unit-tests-java21 58.50% <70.10%> (-0.24%) ⬇️
unit-tests-java8 58.99% <69.79%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants