Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Oct 3, 2025

What is the purpose of the change?

  1. Reset spring version of dubbo-test-spring3.2, dubbo-test-spring4.1 and dubbo-test-spring4.2.
  2. Add profile for them since they could not run on jdk17+.

The spring version of dubbo-test-spring3.2, dubbo-test-spring4.1 and dubbo-test-spring4.2 were accidentally upgraded to the latest version by approving Bump spring version PRs auto-generated by dependabot.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@zrlw zrlw force-pushed the 3.3-remove-dubbo-test-spring4.1and4.2 branch from 3622ad4 to df389a9 Compare October 3, 2025 11:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.10%. Comparing base (dea0206) to head (b9ddcfe).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15715      +/-   ##
============================================
+ Coverage     61.06%   61.10%   +0.03%     
- Complexity    11700    11703       +3     
============================================
  Files          1924     1924              
  Lines         87086    87086              
  Branches      13115    13115              
============================================
+ Hits          53182    53213      +31     
+ Misses        28460    28434      -26     
+ Partials       5444     5439       -5     
Flag Coverage Δ
integration-tests-java21 32.90% <ø> (+0.05%) ⬆️
integration-tests-java8 32.95% <ø> (+<0.01%) ⬆️
samples-tests-java21 32.62% <ø> (+0.04%) ⬆️
samples-tests-java8 30.35% <ø> (+<0.01%) ⬆️
unit-tests-java11 59.09% <ø> (+0.05%) ⬆️
unit-tests-java17 58.71% <ø> (-0.06%) ⬇️
unit-tests-java21 58.70% <ø> (-0.09%) ⬇️
unit-tests-java8 59.08% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-remove-dubbo-test-spring4.1and4.2 branch from df389a9 to 90e6dc5 Compare October 18, 2025 08:51
@zrlw zrlw changed the title [3.3] Remove dubbo-test-spring4.1 and dubbo-test-spring4.2 modules as they are same as dubbo-test-spring3.2 [3.3] Reset spring version of dubbo-test-spring4.1 and dubbo-test-spring4.2 for compatible testing Oct 18, 2025
@zrlw zrlw changed the title [3.3] Reset spring version of dubbo-test-spring4.1 and dubbo-test-spring4.2 for compatible testing [3.3] Reset spring version of dubbo-test-spring3.2, dubbo-test-spring4.1 and dubbo-test-spring4.2 for compatible testing Oct 20, 2025
@zrlw zrlw force-pushed the 3.3-remove-dubbo-test-spring4.1and4.2 branch from 99b71ad to 4cf5dde Compare October 20, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants