-
Notifications
You must be signed in to change notification settings - Fork 26.6k
feat: Implement full zero-copy output for Dubbo Triple protocol #15596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
heliang666s
wants to merge
11
commits into
apache:3.3
Choose a base branch
from
heliang666s:zero-copy
base: 3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9d43dce
feat: Implement full zero-copy output for Dubbo Triple protocol
heliang666s d604888
refactor zero-copy
heliang666s f8caaa5
fix unit-test
heliang666s 1fd8260
Fix ByteBuf leak in zero-copy implementation
heliang666s 904449a
code format
heliang666s 0e44279
Fix compilation errors in AbstractServerHttpChannelObserver
heliang666s 5dafe3b
fix cii bugs
heliang666s 22946b2
code format
heliang666s 30f6911
fix unit-test
heliang666s 6dd13d5
feat: implement zero-copy optimization for HTTP/2 and Triple protocols
heliang666s e92f9fb
style: format code with spotless
heliang666s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,35 @@ | |
| */ | ||
| package org.apache.dubbo.rpc.model; | ||
|
|
||
| import io.netty.buffer.ByteBuf; | ||
| import io.netty.buffer.ByteBufAllocator; | ||
|
|
||
| /** | ||
| * Zero-copy pack interface using ByteBuf | ||
| */ | ||
| public interface Pack { | ||
|
|
||
| /** | ||
| * @param obj instance | ||
| * @return byte array | ||
| * Zero-copy pack object to ByteBuf | ||
| * @param obj instance to pack | ||
| * @param allocator ByteBuf allocator | ||
| * @return ByteBuf containing packed data | ||
| * @throws Exception when error occurs | ||
| */ | ||
| byte[] pack(Object obj) throws Exception; | ||
| ByteBuf pack(Object obj, ByteBufAllocator allocator) throws Exception; | ||
|
||
|
|
||
| /** | ||
| * @deprecated Use {@link #pack(Object, ByteBufAllocator)} for zero-copy processing | ||
| */ | ||
| @Deprecated | ||
| default byte[] pack(Object obj) throws Exception { | ||
| ByteBuf buf = pack(obj, ByteBufAllocator.DEFAULT); | ||
| try { | ||
| byte[] result = new byte[buf.readableBytes()]; | ||
| buf.readBytes(result); | ||
| return result; | ||
| } finally { | ||
| buf.release(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not add Netty as a dependency to the common module.