-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[opt](merge-io) Implement adaptive merge window sizing for MergeRangeFileReader to prevent read amplification #57303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morningman
wants to merge
10
commits into
apache:master
Choose a base branch
from
morningman:merge_io_debug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,109
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
ClickBench: Total hot run time: 27.81 s |
liutang123
reviewed
Oct 24, 2025
| if (gap >= max_single_gap) { | ||
| break; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gap >= max_single_gap meas gap >= SMALL_IO is always true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Summary
Introduced adaptive logic to dynamically control merge window sizing in
MergeRangeFileReader, preventing severe read amplification in sparse data
scenarios while maintaining efficient merging for dense data patterns.
Problem
The original implementation used a fixed merge window (e.g., 8MB) which
worked well for dense columnar data but caused severe read amplification
with sparse ranges:
Example: Large Gap Scenario (3 ranges × 100KB with 600KB gaps)
Solution
Implemented a three-layer adaptive defense mechanism in read_at_impl():
Hard Gap Limit (max_single_gap = 512KB)
Immediately rejects merging if a single gap exceeds 512KB, preventing
catastrophic amplification from huge gaps.
Original Threshold (SMALL_IO = 2MB)
Stops merging when accumulated data > 2MB and next gap ≥ 2MB, maintaining
backward compatibility for typical use cases.
Predictive Gap Ratio Check (adaptive_shrink_threshold = 0.4)
Key Innovation: Proactively checks if including the next gap would push
the gap/content ratio above 40%. Stops merging BEFORE including problematic
gaps, not after.
Performance Results
Scenario 1: Sparse Gaps (15 ranges × 80KB with 50KB gaps)
Before (without adaptive logic):
After (with adaptive logic):
Scenario 2: Dense Gaps (10 ranges × 100KB with 5KB gaps)
Before & After (identical behavior):
Scenario 3: Large Gaps (3 ranges × 100KB with 600KB gaps)
Before (if original logic merged):
After (with max_single_gap=512KB):
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)