Skip to content

Conversation

@linrrzqqq
Copy link
Contributor

What problem does this PR solve?

Issue Number: #48203

Related PR: #xxx

Problem Summary:

Release note

mysql> SELECT `hour`, `minute`, `sec`, MAKETIME(`hour`, `minute`, `sec`) AS ans FROM `test_maketime`;
+-------+--------+---------+-------------------+
| hour  | minute | sec     | ans               |
+-------+--------+---------+-------------------+
|    12 |     15 |      30 | 12:15:30.000000   |
|   111 |      0 | 23.1235 | 111:00:23.123457  |
|  1234 |     11 |       4 | 838:59:59.000000  |
| -1234 |      6 |      52 | -838:59:59.000000 |
|    20 |     60 |      12 | NULL              |
|    14 |     51 |      66 | NULL              |
|  NULL |     15 |      16 | NULL              |
|     7 |   NULL |       8 | NULL              |
|     1 |      2 |    NULL | NULL              |
+-------+--------+---------+-------------------+

mysql> SELECT `hour`, `minute`, MAKETIME(`hour`, `minute`, 27) AS ans FROM `test_maketime`;
+-------+--------+------------+
| hour  | minute | ans        |
+-------+--------+------------+
|    12 |     15 | 12:15:27   |
|   111 |      0 | 111:00:27  |
|  1234 |     11 | 838:59:59  |
| -1234 |      6 | -838:59:59 |
|    20 |     60 | NULL       |
|    14 |     51 | 14:51:27   |
|  NULL |     15 | NULL       |
|     7 |   NULL | NULL       |
|     1 |      2 | 01:02:27   |
+-------+--------+------------+

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb zclllyybb self-assigned this Oct 23, 2025
@linrrzqqq
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b5a305961c3835fc46e7494d8341685574777ec4, data reload: false

query1	0.06	0.06	0.05
query2	0.09	0.06	0.05
query3	0.28	0.08	0.09
query4	1.62	0.12	0.12
query5	0.29	0.26	0.25
query6	1.18	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.61	0.54	0.52
query10	0.58	0.58	0.58
query11	0.17	0.14	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	1.01	1.03	0.99
query15	0.86	0.86	0.87
query16	0.42	0.41	0.38
query17	1.00	1.01	1.07
query18	0.21	0.20	0.20
query19	1.97	1.81	1.77
query20	0.01	0.02	0.01
query21	15.44	0.18	0.13
query22	5.05	0.06	0.05
query23	15.67	0.27	0.11
query24	2.54	0.80	0.40
query25	0.08	0.07	0.07
query26	0.15	0.13	0.14
query27	0.07	0.06	0.06
query28	4.90	1.20	0.93
query29	12.61	3.98	3.31
query30	0.28	0.14	0.12
query31	2.82	0.60	0.38
query32	3.23	0.54	0.47
query33	3.07	3.04	3.00
query34	15.95	5.32	4.56
query35	4.61	4.57	4.50
query36	0.67	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.03
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.05	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.93 s
Total hot run time: 27.52 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 3.23% (1/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 64.52% (20/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 4.55% (3/66) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.62% (17941/34097)
Line Coverage 37.85% (162766/430024)
Region Coverage 32.26% (124062/384619)
Branch Coverage 33.66% (54359/161471)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (66/66) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.34% (23884/33479)
Line Coverage 57.75% (248532/430375)
Region Coverage 52.75% (205681/389886)
Branch Coverage 54.56% (88646/162462)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (66/66) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.37% (23895/33479)
Line Coverage 57.78% (248692/430375)
Region Coverage 52.81% (205882/389886)
Branch Coverage 54.59% (88695/162462)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 64.52% (20/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (66/66) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.36% (23891/33479)
Line Coverage 57.78% (248659/430375)
Region Coverage 52.79% (205828/389886)
Branch Coverage 54.58% (88677/162462)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 64.52% (20/31) 🎉
Increment coverage report
Complete coverage report

yiguolei
yiguolei previously approved these changes Oct 24, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 26, 2025
@linrrzqqq
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 190107 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eae5ac94abf5a6d24bd7be241e3bf1ba9382eeb4, data reload: false

query1	1069	442	430	430
query2	6560	1701	1651	1651
query3	6775	226	220	220
query4	26160	23635	23435	23435
query5	5028	699	485	485
query6	349	254	236	236
query7	4675	530	321	321
query8	319	282	268	268
query9	8751	2591	2615	2591
query10	539	355	300	300
query11	15821	15286	14845	14845
query12	192	119	119	119
query13	1723	590	451	451
query14	13345	9446	9457	9446
query15	265	188	182	182
query16	7822	701	499	499
query17	1622	883	711	711
query18	2110	438	337	337
query19	324	225	197	197
query20	147	136	134	134
query21	302	135	114	114
query22	4637	4647	4574	4574
query23	34764	33577	33969	33577
query24	8216	2490	2516	2490
query25	584	568	485	485
query26	2464	292	162	162
query27	2827	551	387	387
query28	4264	2238	2196	2196
query29	917	625	512	512
query30	302	243	228	228
query31	938	888	785	785
query32	84	71	69	69
query33	591	423	346	346
query34	825	900	538	538
query35	831	892	811	811
query36	950	983	881	881
query37	137	113	98	98
query38	3559	3592	3600	3592
query39	1531	1396	1408	1396
query40	218	125	114	114
query41	59	59	58	58
query42	124	115	110	110
query43	487	495	462	462
query44	1223	738	739	738
query45	183	177	177	177
query46	909	987	634	634
query47	1788	1763	1693	1693
query48	399	424	332	332
query49	778	516	427	427
query50	669	702	397	397
query51	3889	3983	3884	3884
query52	114	106	103	103
query53	236	271	196	196
query54	599	601	542	542
query55	90	89	90	89
query56	325	325	313	313
query57	1171	1201	1126	1126
query58	285	269	276	269
query59	2590	2561	2535	2535
query60	345	353	328	328
query61	165	154	156	154
query62	792	730	686	686
query63	233	195	190	190
query64	4460	1179	850	850
query65	4042	3935	3963	3935
query66	1100	450	336	336
query67	15538	15159	15003	15003
query68	7215	922	589	589
query69	470	332	289	289
query70	1391	1251	1281	1251
query71	474	338	317	317
query72	5958	4979	4986	4979
query73	567	597	355	355
query74	8800	9155	8799	8799
query75	3786	3378	2855	2855
query76	3149	1155	733	733
query77	801	408	314	314
query78	9575	9724	8877	8877
query79	1933	843	596	596
query80	638	577	510	510
query81	490	266	225	225
query82	445	161	136	136
query83	273	284	259	259
query84	258	117	100	100
query85	914	467	421	421
query86	349	298	286	286
query87	3687	3763	3585	3585
query88	3723	2253	2240	2240
query89	386	321	294	294
query90	1989	217	218	217
query91	164	164	137	137
query92	86	69	66	66
query93	1602	972	650	650
query94	693	438	305	305
query95	401	327	315	315
query96	500	586	286	286
query97	2956	2967	2857	2857
query98	238	208	218	208
query99	1458	1423	1276	1276
Total cold run time: 280499 ms
Total hot run time: 190107 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eae5ac94abf5a6d24bd7be241e3bf1ba9382eeb4, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.27	0.25
query6	1.20	0.66	0.66
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.63	0.52	0.53
query10	0.60	0.58	0.58
query11	0.16	0.12	0.12
query12	0.16	0.15	0.12
query13	0.63	0.60	0.60
query14	1.01	1.01	1.02
query15	0.86	0.84	0.86
query16	0.39	0.39	0.40
query17	1.05	1.07	1.04
query18	0.22	0.20	0.19
query19	1.89	1.79	1.76
query20	0.02	0.01	0.02
query21	15.47	0.18	0.12
query22	5.23	0.06	0.05
query23	15.66	0.26	0.12
query24	2.90	1.10	0.38
query25	0.08	0.06	0.06
query26	0.15	0.13	0.13
query27	0.07	0.05	0.05
query28	4.55	1.15	0.94
query29	12.55	4.03	3.34
query30	0.28	0.14	0.10
query31	2.82	0.59	0.39
query32	3.23	0.57	0.47
query33	3.01	3.04	3.06
query34	15.73	5.20	4.58
query35	4.60	4.60	4.57
query36	0.66	0.52	0.49
query37	0.11	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.04
Total cold run time: 98.75 s
Total hot run time: 27.66 s

@linrrzqqq
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 190158 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8edc9f5039c4d1201c76a935b8e1293d2d556222, data reload: false

query1	1046	457	420	420
query2	6591	1703	1727	1703
query3	6757	225	225	225
query4	26143	23511	23181	23181
query5	4807	652	499	499
query6	356	262	243	243
query7	4655	502	315	315
query8	318	297	274	274
query9	8735	2601	2613	2601
query10	540	348	308	308
query11	15640	15018	14796	14796
query12	189	126	126	126
query13	1713	576	463	463
query14	12240	9468	9482	9468
query15	273	196	187	187
query16	7847	694	520	520
query17	1583	776	638	638
query18	2066	493	374	374
query19	526	224	187	187
query20	145	128	148	128
query21	226	133	123	123
query22	4592	4823	4387	4387
query23	34890	33951	33854	33854
query24	8865	2568	2692	2568
query25	599	536	459	459
query26	1232	284	166	166
query27	2820	552	377	377
query28	4328	2253	2224	2224
query29	813	679	535	535
query30	326	239	218	218
query31	950	874	790	790
query32	88	76	74	74
query33	605	420	346	346
query34	826	904	546	546
query35	870	877	807	807
query36	997	985	908	908
query37	139	112	91	91
query38	3560	3581	3483	3483
query39	1495	1455	1418	1418
query40	224	128	120	120
query41	61	61	60	60
query42	125	118	112	112
query43	486	492	465	465
query44	1269	754	738	738
query45	187	186	177	177
query46	899	1019	653	653
query47	1731	1777	1699	1699
query48	409	439	316	316
query49	774	533	439	439
query50	672	696	427	427
query51	3925	3909	3868	3868
query52	115	113	109	109
query53	250	288	219	219
query54	608	616	551	551
query55	90	90	84	84
query56	344	329	324	324
query57	1162	1175	1115	1115
query58	296	284	279	279
query59	2545	2637	2472	2472
query60	361	347	337	337
query61	161	151	156	151
query62	787	728	672	672
query63	244	201	202	201
query64	4413	1184	872	872
query65	4063	3983	4008	3983
query66	1088	436	336	336
query67	15387	15234	14960	14960
query68	9065	969	604	604
query69	488	334	298	298
query70	1369	1295	1238	1238
query71	486	344	321	321
query72	5599	4894	4804	4804
query73	699	582	363	363
query74	8980	9062	8666	8666
query75	4398	3377	2836	2836
query76	3715	1211	775	775
query77	818	439	344	344
query78	9583	9809	8878	8878
query79	1870	881	612	612
query80	689	612	530	530
query81	496	267	236	236
query82	456	178	138	138
query83	290	284	269	269
query84	263	122	96	96
query85	911	490	443	443
query86	344	313	293	293
query87	3755	3702	3656	3656
query88	3150	2284	2245	2245
query89	422	324	302	302
query90	2033	238	229	229
query91	169	167	137	137
query92	93	78	66	66
query93	1165	972	640	640
query94	692	443	347	347
query95	415	333	329	329
query96	517	583	285	285
query97	2922	2974	2880	2880
query98	246	225	212	212
query99	1458	1438	1317	1317
Total cold run time: 280623 ms
Total hot run time: 190158 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.99 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8edc9f5039c4d1201c76a935b8e1293d2d556222, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.28	0.27	0.26
query6	1.18	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.53	0.52
query10	0.59	0.58	0.58
query11	0.16	0.12	0.12
query12	0.18	0.13	0.13
query13	0.62	0.60	0.60
query14	1.02	1.02	1.01
query15	0.86	0.85	0.87
query16	0.40	0.40	0.40
query17	1.00	1.05	1.03
query18	0.21	0.21	0.20
query19	1.91	1.85	1.88
query20	0.02	0.01	0.02
query21	15.45	0.18	0.13
query22	5.08	0.08	0.05
query23	15.64	0.28	0.12
query24	2.56	0.66	0.83
query25	0.08	0.07	0.06
query26	0.14	0.12	0.12
query27	0.08	0.06	0.06
query28	5.12	1.16	0.95
query29	12.56	4.02	3.31
query30	0.31	0.14	0.11
query31	2.82	0.61	0.39
query32	3.23	0.55	0.48
query33	3.03	3.05	3.03
query34	16.01	5.20	4.52
query35	4.57	4.56	4.55
query36	0.70	0.51	0.49
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.04
query42	0.04	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 99.09 s
Total hot run time: 27.99 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 3.23% (1/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 64.52% (20/31) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2025
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 58.06% (18/31) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants