refactor: Apply minor refactorings to functions-array crate
#9788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenavsarogullari
changed the title
functions-array createfunctions-array crate
alamb
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Thank you @erenavsarogullari -- this looks like a very nice improvement to me
datafusion/functions-array/README.md
Outdated
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| [DataFusion][df] is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format. | |||
|
|
|||
| This crate contains functions for working with arrays, such as `array_append` that work with | |||
| This crate contains functions for working with arrays, such as `array_append` that works with | |||
There was a problem hiding this comment.
I think the original was more correct as functions is plural
| pub fn array_resize_inner(arg: &[ArrayRef]) -> datafusion_common::Result<ArrayRef> { | ||
| pub(crate) fn array_resize_inner( | ||
| arg: &[ArrayRef], | ||
| ) -> datafusion_common::Result<ArrayRef> { |
There was a problem hiding this comment.
Should we also change this to just Result<ArrayRef>?
There was a problem hiding this comment.
Addressed by covering functions-array crate. Please see commit: 638c3a7
|
Thanks @alamb and @jayzhan211 for the reviews and feedback. |
alamb
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9787.
What changes are included in this PR?
This PR aims to do following refactoring:
1- Being added
make_scalar_functionsupport to missedinvokefunctions,2- Aligning rust-doc across array functions,
3- Removing redundant imports,
4- Fixing typo problems,
5- Rename
core.rs->make_array.rs.Are these changes tested?
Yes, all
array.slttests pass.Are there any user-facing changes?
No