Add schema_err! error macros with optional backtrace#8620
Add schema_err! error macros with optional backtrace#8620comphead merged 9 commits intoapache:mainfrom
schema_err! error macros with optional backtrace#8620Conversation
| rust-version: stable | ||
| - name: Run tests (excluding doctests) | ||
| run: cargo test --lib --tests --bins --features avro,json,backtrace | ||
| env: |
There was a problem hiding this comment.
Adding more stack as q54 keeps failing.
thread 'tpcds_physical_q54' has overflowed its stack
This PR shouldn't impact stack as the introduced SchemaError second param is boxed and thus resides in heap, in stack there is only a pointer. However it is what is is, I'm happy to get the opinion from other contributors on this
|
@alamb would you mind reviewing? |
a0fa96c to
73b1f16
Compare
|
Here the problem is backtrace-rs regression in Rust lang |
Wow -- super sleuth 🕵️ |
Tbh, all kudos to @Jefffrey who ran tons of experiments to narrow down the problem when we were investigating windows CI slowness, and eventually he came to backtrace root cause. |
Which issue does this PR close?
Closes partially #7360.
Rationale for this change
Continue covering Datafusion Errors with error macros supporting optional backtrace
What changes are included in this PR?
introduced
schema_err!andschema_datafusion_err!macros with optional backtrace, to representErr(DatafusionError::SchemaError)andDatafusionError::SchemaError(_)Are these changes tested?
Yes
Are there any user-facing changes?
No