[execution] Remove deprecated disk manager configuration API#23139
Open
megakaizo wants to merge 3 commits into
Open
[execution] Remove deprecated disk manager configuration API#23139megakaizo wants to merge 3 commits into
megakaizo wants to merge 3 commits into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
|
@alamb (and any other reviewer) — another #23080 partial removal: |
Contributor
|
LGTM, thank you! |
2010YOUY01
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
DiskManagerConfigandDiskManager::try_newwere deprecated in version 48.0.0 in favor of the newDiskManagerBuilder. This PR remove this deprecated methods and update Runtime env initialization logicWhat changes are included in this PR?
RuntimeEnvBuilder::with_disk_managerdepercated method.DiskManagerConfigenum and its associated constructor methods.DiskManager::try_newmethod.RuntimeEnvBuilderto storeOption<Arc<DiskManager>>instead of the old configuration enum.RuntimeEnvBuilder::buildlogic by using matching to handle the existing manager, builder, or default initialization.Are these changes tested?
verifed by running local tests
Are there any user-facing changes?
Yes. This removes the deprecated public Rust APIs
RuntimeEnvBuilder::with_disk_manager,DiskManagerConfigandDiskManager::try_new. Downstream users who need to configure the disk manager should migrate to usingDiskManager::builder.This is an API change and should be labeled as
api change.