fix: Disallow implicit coercion between string and numeric types in binary operators#20456
Open
neilconway wants to merge 3 commits intoapache:mainfrom
Open
fix: Disallow implicit coercion between string and numeric types in binary operators#20456neilconway wants to merge 3 commits intoapache:mainfrom
neilconway wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
logical-expr
neilconway
force-pushed
the
neilc/type-coercion-literal
branch
from
d3c69fa to
22f45bb
Compare
neilconway
force-pushed
the
neilc/type-coercion-literal
branch
from
22f45bb to
1b710f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR and #20426 are two different approaches to fixing #15161. In this approach, we don't allow string to numeric coercion in comparison contexts at all. We then teach the type coercion analyzer to allow comparisons of that kind, as long as an integer column is being compared with a string literal (
int_col < '5') should be allowed. This means thattext_col = 5andint_col = text_colare both rejected. Similarly,int_col IN ('5')andint_col BETWEEN '5' and '10'are allowed, whiletext_col IN (5)is rejected.We continue to allow flexible type widening for UNIONs, so
SELECT 1 UNION ALL SELECT 'hello'continues to work (personally I think this is very dubious behavior; Postgres disallows it but DuckDB and ClickHouse allow it.) We also allow mixed types inCASEstatements.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?