Draft
Conversation
github-actions
bot
added
common
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT until #19469 merges
Which issue does this PR close?
ConfigOptionsto scalar functions via FFI #17035Rationale for this change
Now that we have proper
FFI_ConfigOptionswe can pass these to scalar UDFs via FFI.What changes are included in this PR?
Instead of passing default options, pass in converted config options from the input.
Also did a drive by cleanup of switching to using FFI_ColumnarValue since it is now available.
Are these changes tested?
Unit test added.
Are there any user-facing changes?
This is a breaking API change, but not one that users will interact with directly. It breaks the ABI for FFI libraries, which is currently unstable.