Clamp early aggregation emit to the sort boundary when using partial group ordering#20446
Open
jackkleeman wants to merge 2 commits intoapache:mainfrom
Open
Clamp early aggregation emit to the sort boundary when using partial group ordering#20446jackkleeman wants to merge 2 commits intoapache:mainfrom
jackkleeman wants to merge 2 commits intoapache:mainfrom
Conversation
jackkleeman
force-pushed
the
issue-20445
branch
from
3ce1b2b to
e3b1045
Compare
jackkleeman
force-pushed
the
issue-20445
branch
from
e3b1045 to
f5382f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GroupOrderingPartial::remove_groupswhen Partial aggregate with PartiallySorted hits memory pressure #20445.What changes are included in this PR?
Fix a panic on early emit with partial sort aggregations, by clamping our emit point to the sort boundary
Are these changes tested?
Yes
Are there any user-facing changes?
No