Adds summary output to CLI instrumented object stores #18045
Merged
+284
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This does not fully close, but is an incremental building block component for:
datafusion-cli
] Add a way to see what object store requests are made #17207The full context of how this code is likely to progress can be seen in the POC for this effort:
Rationale for this change
For particularly large requests, in terms of number of objects in a table or large objects, the number of operations for a query may be quite large. In these cases, understanding the aggregate impact of various object store operations is likely the best way to understand the impact those operations had on a particular query. This PR allows users of an instrumented object store to understand and display basic summary statistics related to the
RequestDetails
collected during a query.What changes are included in this PR?
RequestSummary
type for the instrumented object store to display summary statistics about instrumented requestsAre these changes tested?
Yes. The new functionality has tests implemented, aside from testing the actual display output. The functional output can be seen below:
Are there any user-facing changes?
Yes? Just like the previous PR this does change the user-facing output, but there's no API breaking changes.
cc @alamb