-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feat: Make current_time aware of execution timezone. #18040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codetyri0n
wants to merge
7
commits into
apache:main
Choose a base branch
from
codetyri0n:current_time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
43b73f8
Feat: Make current_time aware of execution timezone.
codetyri0n 4a3ff7f
Chore: Refactor timezone conversion logic and add helper function.
codetyri0n 9c9f094
Merge branch 'main' into current_time
codetyri0n 5b603c3
Comment out flaky test.
codetyri0n e4e7898
Merge branch 'main' into current_time
codetyri0n 7936c9c
Improved docs and added unit test to verify timezone aware execution.
codetyri0n 3f5be2f
CI fixes: fix clippy failure.
codetyri0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
datafusion/sqllogictest/test_files/current_time_timezone.slt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
|
||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
########## | ||
## current_time with timezone tests | ||
########## | ||
|
||
# Test 1: Verify current_time is consistent within the same query (default UTC) | ||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 2: Verify data type is correct | ||
query T | ||
SELECT arrow_typeof(current_time()); | ||
---- | ||
Time64(Nanosecond) | ||
|
||
# Test 3: Set timezone to +08:00 and verify current_time is still stable | ||
statement ok | ||
SET datafusion.execution.time_zone = '+08:00'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
codetyri0n marked this conversation as resolved.
Show resolved
Hide resolved
|
||
---- | ||
true | ||
|
||
# Test 4: Verify current_time returns Time64 type in different timezone | ||
query T | ||
SELECT arrow_typeof(current_time()); | ||
---- | ||
Time64(Nanosecond) | ||
|
||
# Test 5: Test with negative offset timezone | ||
statement ok | ||
SET datafusion.execution.time_zone = '-05:00'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 6: Test with named timezone (America/New_York) | ||
statement ok | ||
SET datafusion.execution.time_zone = 'America/New_York'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 7: Verify current_time is stable within a query | ||
query B | ||
SELECT | ||
current_time() = current_time() AND | ||
current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 8: Reset to UTC | ||
statement ok | ||
SET datafusion.execution.time_zone = '+00:00'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 9: Verify current_time with Asia/Tokyo timezone | ||
statement ok | ||
SET datafusion.execution.time_zone = 'Asia/Tokyo'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true | ||
|
||
# Test 10: Verify current_time with Europe/London timezone | ||
statement ok | ||
SET datafusion.execution.time_zone = 'Europe/London'; | ||
|
||
query B | ||
SELECT current_time() = current_time(); | ||
---- | ||
true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.