Fix SortPreservingMergeExec tree formatting with limit
#18009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
AdamGS
force-pushed
the
adamg/fix-sort-merge-exec-tree-fmt-limit
branch
from
1b56fc3 to
8f009a2
Compare
AdamGS
changed the title
SortPreservingMergeExec tree formatting with limit
alamb
approved these changes
Oct 10, 2025
|
|
||
| if let Some(fetch) = self.fetch { | ||
| writeln!(f)?; | ||
| writeln!(f, "limit={fetch}")?; |
There was a problem hiding this comment.
I wonder if the last one should be just write! rather than writeln! 🤔
There was a problem hiding this comment.
Alternatively, we could move the previous logic before the PhysicalSortExec iteration, which would be more intuitive.
There was a problem hiding this comment.
@Weijun-H took your suggestion, definitely cleaner
AdamGS
force-pushed
the
adamg/fix-sort-merge-exec-tree-fmt-limit
branch
from
8f009a2 to
3fac54b
Compare
Weijun-H
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SortPreservingMergeExectree formatting with limit is missing a new line #18008.The PR is split into two commits, the first one includes a passing test that shows the bug, and the second PR fixes the formatting and the test.
Rationale for this change
Fixes tree formatting for
SortPreservingMergeExecWhat changes are included in this PR?
Fix tree formatting for
SortPreservingMergeExecand add a test for the behavior.Are these changes tested?
A new slt test
Are there any user-facing changes?
Only if a user asserts the tree-display in this case.