Skip to content

fix: ParquetSource - with_predicate() don't have to reset metrics #17858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Oct 4, 2025
Merged

fix: ParquetSource - with_predicate() don't have to reset metrics #17858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions datafusion/datasource-parquet/src/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,9 @@ impl ParquetSource {
self
}

fn with_metrics(mut self, metrics: ExecutionPlanMetricsSet) -> Self {
Copy link
Member

@martin-g martin-g Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional ?
It is not related to with_predicate()

Copy link
Contributor Author

@2010YOUY01 2010YOUY01 Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with_predicate() is the only place calling this deleted function, and now it's removed

Copy link
Member

@martin-g martin-g Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!
with_metrics() was private!
But there is no setter for metrics now... How is it supposed to be used ? Use directly the field ?!

self.metrics = metrics;
self
}

/// Set predicate information
pub fn with_predicate(&self, predicate: Arc<dyn PhysicalExpr>) -> Self {
Copy link
Member

@martin-g martin-g Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is a bit strange.
The other with_**() methods accept mut self and modify in-place. Only this method accepts &self and makes a clone of itself.

Copy link
Contributor

@alamb alamb Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be nice to figure out why there is this discrepancy

Copy link
Contributor

@alamb alamb Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #17917 to track

let mut conf = self.clone();
let metrics = ExecutionPlanMetricsSet::new();
conf = conf.with_metrics(metrics);
conf.predicate = Some(Arc::clone(&predicate));
conf
}
Expand Down
Loading