Skip to content

CI: Fix extended test failure #16144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

CI: Fix extended test failure #16144

merged 1 commit into from
May 22, 2025

Conversation

2010YOUY01
Copy link
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

The extended test (job linux-test-extended) in CI is failing because of changes introduced in #16081. This PR added several failing snapshot tests for CLI integration. The CLI integration tests in CI run with backtrace disabled, while the extended tests run with backtrace enabled, which is causing the discrepancies.

Since the purpose of the failing CI job is only for tests guarded by the extended_test feature, and we don't have any for CLI tests, we can exclude CLI tests from the extended test suite.

Failed CI run: https://github.com/apache/datafusion/actions/runs/15179660797/job/42686605128
Failed CI job script:

linux-test-extended:

What changes are included in this PR?

Exclude datafusion-cli test from CI extended test, job linux-test-extended

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label May 22, 2025
@2010YOUY01
Copy link
Contributor Author

2010YOUY01 commented May 22, 2025

I'm testing it in my local clone: https://github.com/2010YOUY01/arrow-datafusion/actions/runs/15182434324
Update: passed

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @2010YOUY01 !

@blaginin
Copy link
Contributor

Another potential solution: use something like

settings.add_filter(r"Elapsed .* seconds\.", "[ELAPSED]");
to filter out stacktrace

@blaginin
Copy link
Contributor

I think other actions fail with the same error here? 🤔
https://github.com/apache/datafusion/actions/runs/15183361207/job/42699605764?pr=16145

@ding-young
Copy link
Contributor

I think other actions fail with the same error here? 🤔 https://github.com/apache/datafusion/actions/runs/15183361207/job/42699605764?pr=16145

For that one, I think the author replaced B with bytes in the tests , so we need to check it again after fixing that

@2010YOUY01
Copy link
Contributor Author

Another potential solution: use something like

settings.add_filter(r"Elapsed .* seconds\.", "[ELAPSED]");

to filter out stacktrace

Yes, I think this is also required for other similar usages. I think showing backtrace is common for error tests, it would be great to have a utility function for that.

@blaginin
Copy link
Contributor

Created a separate issue #16146

Let's merge this PR for now to make the CI green 💚

@blaginin blaginin merged commit 67a2173 into apache:main May 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants