chore: Reduce repetition in the parameter type inference tests #16079
+44
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb Yep I just need to fix that clippy issue and then I'll add it to the rest of the tests. I'll probably just do it in this PR itself |
alamb
reviewed
May 20, 2025
Comment on lines
+64
to
+65
| #[allow(clippy::needless_lifetimes)] | ||
| impl<'a> ParameterTest<'a> { |
There was a problem hiding this comment.
I think you can avoid the clippy issue with something like this:
Suggested change
| #[allow(clippy::needless_lifetimes)] | |
| impl<'a> ParameterTest<'a> { | |
| impl ParameterTest<'_> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #16057.
Rationale for this change
Reduces repetition in the parameter type inference tests
What changes are included in this PR?
Added a
ParameterTesttype to easily create parameter type inference tests.Are these changes tested?
Tests run successfully.
Are there any user-facing changes?
No.