Skip to content

[Docs]: Added SQL example for all window functions #16074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

Adez017
Copy link
Contributor

@Adez017 Adez017 commented May 17, 2025

Which issue does this PR close?

Rationale for this change

Added SQl example for different functions in the window functions docs

Are there any user-facing changes?

yes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 17, 2025
@Adez017
Copy link
Contributor Author

Adez017 commented May 17, 2025

@alamb could you trigger the CI . also I think there might be need for running ./dev/update_function_docs.sh as I think its halting in my machine .

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Adez017

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the examples updated in md files it would be needed to update Documentation builders

@comphead comphead self-requested a review May 17, 2025 18:22
@Adez017
Copy link
Contributor Author

Adez017 commented May 18, 2025

To get the examples updated in md files it would be needed to update Documentation builders

Thanks for suggestion mate I fired ./dev/update_function_docs.sh but I think its not working on my machine as I didn't get the successfully updated message in terminal . because of this particular reason I think someone need to do that @comphead @alamb also previously it checked 27 CI jobs , so I think we need to trigger that CI also

@Adez017
Copy link
Contributor Author

Adez017 commented May 19, 2025

@alamb @comphead @xudong963 please have a look

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Adez017 and @comphead !

@alamb alamb merged commit e74ae7d into apache:main May 19, 2025
5 checks passed
@alamb
Copy link
Contributor

alamb commented May 19, 2025

I think I accidentally merged this without running update_functions_docs.sh first 😢 (I thought the CI was green, but clearly I misread the UI)

I will make a follow on PR to fix

@alamb
Copy link
Contributor

alamb commented May 19, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add SQL Example for Aggregate functions
3 participants