-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(CI) Upgrade toolchain to Rust-1.87 #16068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI) Upgrade toolchain to Rust-1.87 #16068
Conversation
c111d03
to
df88591
Compare
df88591
to
b69ad61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @kadai0308 -- very helpful
I am not sure about the implications of Box
ing all the variants -- I worry it will just add additional overhead for planning and API churn (though I'll run some benchmarks0
Rather than adding new Box
would you be willing instead to add in the #[clippy(allow(..))
annotations instead for errors about mismatched enum sizes?
I think this would allow us to unblock the upgrade to 1.87 and we can then consider how to fix the enum variant size mismatch as a follow on
For example, one thing I would like to consider is making Expr
smaller, for example, this PR: #14366
b69ad61
to
5bd7dc8
Compare
Thanks for the feedback! Yeah, I agree — adding Box to some enum variants and the associated changes could make the codebase and API more unstable and fragile. Another notable change is related to this warning:
It seems we could return Option instead of AvroResult, because
If I understand correctly, .ok()? effectively drops the error from AvroResult, making Option sufficient in this context. |
5bd7dc8
to
3edb3e9
Compare
3edb3e9
to
9d3f1bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kadai0308 and @findepi
Which issue does this PR close?
Rationale for this change
Improve build times.
What changes are included in this PR?
Updating toolchain to Rust 1.87 and fixing associated errors and warnings.
The main changes including:
datafusion/common/src/stats.rs:355:9
and the following related changesdatafusion/expr/src/planner.rs:315:1
and the following related changesdatafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:523:1
and the following related changesdatafusion/physical-plan/src/aggregates/mod.rs:349:1
and the following related changesdatafusion/datasource-avro/src/avro_to_arrow/arrow_array_reader.rs:941:29
Are these changes tested?
Are there any user-facing changes?