Fix: common_sub_expression_eliminate optimizer rule failed #16066
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common_sub_expression_eliminate rule failed with error:
`SchemaError(FieldNotFound {field: <name>}, valid_fields: []})`
due to the schema being changed by the second application of
`find_common_exprs`
As I understood the source of the problem was in sequential call of
`find_common_exprs`. First call returned original names as `aggr_expr`
and changed names as `new_aggr_expr`. Second call takes into account
only `new_aggr_expr` and if names was already changed by first call
will return changed names as `aggr_expr`(original ones)
and put them into Projection logic.
I used NamePreserver mechanism to restore original schema names and
generate Projection with original name at the end of aggregate
optimization.
github-actions
bot
added
optimizer
alamb
reviewed
May 16, 2025
| .map(|expr| Some(name_preserver.save(expr))) | ||
| .collect::<Vec<_>>() | ||
| } else { | ||
| new_aggr_expr |
There was a problem hiding this comment.
Is this the same as a vec of all None?
vec![None; new_agg_expr.len()]`There was a problem hiding this comment.
Yes it is, thanks for the comment. But this will not work, because vec! requires value to implement Clone trait but the Option<SavedName> doesn't. It seems to me easier to do this by map instead of adding trait to SavedName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Common_sub_expression_eliminate rule failed with error:
SchemaError(FieldNotFound {field: <name>}, valid_fields: []})due to the schema being changed by the second application of
find_common_exprsAs I understood the source of the problem was in sequential call of
find_common_exprs. First call returned original names asaggr_exprand changed names as
new_aggr_expr. Second call takes into accountonly
new_aggr_exprand if names was already changed by first callwill return changed names as
aggr_expr(original ones)and put them into Projection logic.
What changes are included in this PR?
I used existing NamePreserver mechanism to restore original schema names and
generate Projection with original name at the end of aggregate optimization.
Are these changes tested?
Yes this changes are tested and I added test to this commit.
Error emerges not only in PREPARE requests, I created SELECT request which
causes the same error.
Are there any user-facing changes?
No the change only fixes optimization rule.