Handle union schema name coercion #16064
Open
+357
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiaCastaneda
changed the title
gabotechs
reviewed
May 16, 2025
| #[tokio::test] | ||
| async fn test_multiple_unions() -> Result<()> { | ||
| let plan_str = test_plan_to_string("multiple_unions.json").await?; | ||
| assert_eq!( |
There was a problem hiding this comment.
How about using assert_snapshot! here? seems to be a more up-to-date approach for snapshot testing
Comment on lines
-535
to
-536
| // We can unwrap this because if inputs was empty, this would've already panic'ed when we | ||
| // indexed into inputs[0]. |
There was a problem hiding this comment.
I imagine that this comment is still relevant right? we might want to keep it.
| @@ -513,7 +513,10 @@ fn union_schema(inputs: &[Arc<dyn ExecutionPlan>]) -> SchemaRef { | |||
|
|
|||
| let fields = (0..first_schema.fields().len()) | |||
| .map(|i| { | |||
| inputs | |||
| let base_field = first_schema.field(i).clone(); | |||
There was a problem hiding this comment.
How about adding a comment about why is important to keep the name of the column from the first schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Physical planning is failing on the uppermost projection due to inaccurate schema name coercion while building the union physical node
UnionExec(see issue for wider explanation)What changes are included in this PR?
A workaround fix in
union_schemaby keeping the field names of the first input + a integration test with a reproducer.Are these changes tested?
yes, a test was added in
substrait_consumertestsAre there any user-facing changes?
no