Skip to content

chore: Upgrade rand crate and some other minor crates #16062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

chore: Upgrade rand crate and some other minor crates #16062

wants to merge 23 commits into from
+1,060 −1,023

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Replaces #14967

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@comphead comphead changed the title chore: Upgrade rand crate and some other minor crates #14967 chore: Upgrade rand crate and some other minor crates May 15, 2025
@comphead comphead mentioned this pull request May 17, 2025
Closed
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates core Core DataFusion crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate labels May 18, 2025
alamb
alamb approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @comphead

I took the liberty of merging up from main to try and resolve the merge conflicts

@alamb alamb marked this pull request as ready for review May 18, 2025 20:26
@comphead
Copy link
Contributor Author

I'm trying to resolve wasm

comphead
comphead commented May 19, 2025
View reviewed changes
datafusion/core/tests/parquet/filter_pushdown.rs
//
// Reason: Data generated by
// `StdRng::from_seed` varies in `generate_file` test data generator
#[ignore]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out this tests, but since they look important I'm planning to create separate parquet files for it in other PR, most likely predecessing this PR

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label May 19, 2025
comphead added 14 commits May 19, 2025 17:06
@github-actions github-actions bot added the development-process Related to development process of DataFusion label May 20, 2025
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label May 20, 2025
@github-actions github-actions bot added the development-process Related to development process of DataFusion label May 20, 2025
@comphead
Copy link
Contributor Author

Finally there is a green build. Please do not merge it until I fix ignored tests which will be in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate development-process Related to development process of DataFusion execution Related to the execution crate functions Changes to functions implementation physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comphead @alamb