Skip to content

Fix off by 1 in decimal cast to lower precision #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix off by 1 in decimal cast to lower precision #14731

merged 1 commit into from
Feb 18, 2025

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 17, 2025

@findepi
Fix off by 1 in decimal cast to lower precision
71156dd 
Upgrade to arrow-rs bug fix release.
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 17, 2025
@findepi findepi mentioned this pull request Feb 17, 2025
Closed
alamb
alamb approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi

@alamb alamb merged commit 04dc656 into apache:main Feb 18, 2025
26 checks passed
@Blizzara
Copy link
Contributor

Thanks both!

@findepi findepi deleted the findepi/fix-off-by-1-in-decimal-cast-to-lower-precision-6a2b86 branch February 18, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@crepererum crepererum Awaiting requested review from crepererum

@comphead comphead Awaiting requested review from comphead

Assignees
No one assigned
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect result for decimal cast
3 participants
@findepi @Blizzara @alamb