Make LexOrdering::inner non pub, add comments, update usages#14155
Merged
comphead merged 1 commit intoapache:mainfrom Jan 17, 2025
Merged
Make LexOrdering::inner non pub, add comments, update usages#14155comphead merged 1 commit intoapache:mainfrom
LexOrdering::inner non pub, add comments, update usages#14155comphead merged 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
physical-expr
alamb
commented
Jan 16, 2025
| #[derive(Debug, Default, Clone, PartialEq, Eq, Hash)] | ||
| pub struct LexOrdering { | ||
| pub inner: Vec<PhysicalSortExpr>, | ||
| inner: Vec<PhysicalSortExpr>, |
Contributor
Author
There was a problem hiding this comment.
this is the core change of this PR -- to make this field non pub. All the rest of the changes follow from there
berkaysynnada
approved these changes
Jan 17, 2025
Contributor
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
LGTM, thank you @alamb. After your work on these equivalence API's, they seem more clear and easy to use now.
Contributor
Author
Thank you -- now I just need to make them faster / more efficient It is a good intellectual / algorithmic challenge :) |
Contributor
Author
|
Thank you @berkaysynnada and @comphead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
UNIONandORDER BYqueries #13748Rationale for this change
In order to optimize the ordering calculations, we may need to change how the structures are represented internally.
Since all the inner fields are
pubmaking such changes requires too many changes over the codebaseWhat changes are included in this PR?
LexOrdering::innernon pub,Are these changes tested?
Yes, by existing CI
Are there any user-facing changes?
This is a deliberate API change that forces all
LexOrderingobject to be created via constructor rather than directly