Fix identifier parsing not breaking on the |> pipe operator
#2156
+363
−252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in Pipe SQL parsing with identifiers followed by the
|>operator.Fix
parse_identifiersneeds to break onToken::VerticalBarRightAngleBracketas well, otherwise it continues to consume the following tokens asIdent(until one of the other break conditions is encountered).Example
Without the fix the DROP section consumes the RENAME tokens as identifiers:
After the fix the identifier boundary is respected, and the operations parse correctly:
Also
Updated the pipe operator tests with some new coverage for the above, and a helper that additionally validates queries that start
"FROM <tbl>"(in addition to"SELECT * FROM <tbl>") with the pipe operator.