Postgres: Support INTERVAL data type options
#1984
Open
+237
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 31, 2025
[Postgres] allows extra options for the `INTERVAL` data type; namely fields and subsecond precision. For example `'3 years 1 second'::interval year to month` casts the interval and strips the seconds, and `'1.3333 seconds'::interval(1)` returns `1.3` seconds. This is supported by adding two optional fields to `DataType::Interval`, along with a new `enum` for the allowed fields. Note that [MSSQL] also supports similar options, but with more complicated precision syntax, e.g. `INTERVAL HOUR(p) TO SECOND(q)`. This is not implemented in this commit because I don't have a way to test it. [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html [MSSQL]: https://learn.microsoft.com/en-us/sql/odbc/reference/appendixes/sql-data-types?view=sql-server-ver17
mvzink
force-pushed
the
push-mnyzxktlvzrp
branch
from
c1096a8 to
54ef1f7
Compare
iffyio
reviewed
Aug 1, 2025
Comment on lines
+350
to
+355
| /// Optional [Postgres] field list and precision: `interval [ fields ] [ (p) ]` | ||
| /// | ||
| /// [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html | ||
| Interval { | ||
| fields: Option<IntervalFields>, | ||
| precision: Option<u64>, |
There was a problem hiding this comment.
Suggested change
| /// Optional [Postgres] field list and precision: `interval [ fields ] [ (p) ]` | |
| /// | |
| /// [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html | |
| Interval { | |
| fields: Option<IntervalFields>, | |
| precision: Option<u64>, | |
| Interval { | |
| /// `Example syntax` | |
| /// | |
| /// [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html | |
| fields: Option<IntervalFields>, | |
| /// `Example syntax` | |
| /// | |
| /// [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html | |
| precision: Option<u64>, |
Could we move the documentation to the individual properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres allows extra options for the
INTERVALdata type; namely fields and subsecond precision. For example'3 years 1 second'::interval year to monthcasts the interval and strips the seconds, and'1.3333 seconds'::interval(1)returns1.3seconds.This is supported by adding two optional fields to
DataType::Interval, along with a newenumfor the allowed fields.Note that MSSQL also supports similar options, but with more complicated precision syntax, e.g.
INTERVAL HOUR(p) TO SECOND(q). This is not implemented in this commit because I don't have a way to test it.