-
Notifications
You must be signed in to change notification settings - Fork 245
fix: Support scalar/array args for rpad/read_side_padding #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
============================================
+ Coverage 56.12% 58.40% +2.28%
- Complexity 976 1436 +460
============================================
Files 119 146 +27
Lines 11743 13510 +1767
Branches 2251 2350 +99
============================================
+ Hits 6591 7891 +1300
- Misses 4012 4389 +377
- Partials 1140 1230 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Failed spark test case:
|
@coderfender as were working on rpad/lpad |
Thank you for the info, feel free to take over this. |
@wForget , If my understanding is right, you are adding support to non scalar args to |
Which issue does this PR close?
Closes #2475.
Rationale for this change
Support full scalar/array arguments for rpad/read_side_padding
What changes are included in this PR?
Use
make_scalar_function
to convert arguments to arrays.How are these changes tested?
unit test