fix: Re-enable Spark 4 tests on Linux #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
============================================
+ Coverage 56.12% 59.47% +3.34%
- Complexity 976 1140 +164
============================================
Files 119 128 +9
Lines 11743 12531 +788
Branches 2251 2356 +105
============================================
+ Hits 6591 7453 +862
+ Misses 4012 3887 -125
- Partials 1140 1191 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
reviewed
May 28, 2025
| @@ -50,10 +49,53 @@ jobs: | |||
| java_version: [17] | |||
| test-target: [java] | |||
| spark-version: ['4.0'] | |||
| is_push_event: | |||
| - ${{ github.event_name == 'push' }} | |||
| suites: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1786
Part of #1800
Rationale for this change
Rather than run all of the tests sequentially in a single process, split them into groups and run them in parallel. This somehow avoids the issue with the process eventually becoming unresponsive. If the problem starts again, it will be easier to isolate with this approach.
This approach may also reduce overall CI time if we apply it to other Spark versions as well.
Before
Based on run in https://github.com/apache/datafusion-comet/actions/runs/15219754440/job/42813062845
After
exec
fuzz
parquet
shuffle
What changes are included in this PR?
How are these changes tested?