chore: Enable CometFuzzTestSuite int96 test for experimental native scans (without complex types) #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut without complex types.
mbutrovich
changed the title
andygrove
approved these changes
Apr 21, 2025
comphead
reviewed
Apr 21, 2025
| @@ -206,10 +206,15 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| } | |||
|
|
|||
| private def testParquetTemporalTypes( | |||
| outputTimestampType: ParquetOutputTimestampType.Value): Unit = { | |||
| outputTimestampType: ParquetOutputTimestampType.Value, | |||
| generateArray: Boolean = true, | |||
There was a problem hiding this comment.
should we also generate maps?
There was a problem hiding this comment.
It would be good to start testing maps as well in the fuzz suite. Some of the existing tests cannot work with map types though (because maps don't implementing ordering). We may need to add new map-specific tests.
There was a problem hiding this comment.
For this PR I'd just like to match existing functionality. We should open an issue to add map coverage to the CometFuzzTestSuite.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
============================================
+ Coverage 56.12% 58.81% +2.68%
- Complexity 976 1082 +106
============================================
Files 119 125 +6
Lines 11743 12592 +849
Branches 2251 2362 +111
============================================
+ Hits 6591 7406 +815
- Misses 4012 4015 +3
- Partials 1140 1171 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kazuyukitanimura
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
#1652 added better int96 support for experimental native scans (relying on CometCastSuite and other Parquet tests) but did not enable CometFuzzTestSuite because it uses complex types by default. There's an issue in DF's schema coercion for complex types.
What changes are included in this PR?
This PR modifies the test to get coverage with the int96 data type without complex types.
How are these changes tested?
New test coverage.