chore: Simplify on-heap memory configuration #7694
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Licensed to the Apache Software Foundation (ASF) under one | |
| # or more contributor license agreements. See the NOTICE file | |
| # distributed with this work for additional information | |
| # regarding copyright ownership. The ASF licenses this file | |
| # to you under the Apache License, Version 2.0 (the | |
| # "License"); you may not use this file except in compliance | |
| # with the License. You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, | |
| # software distributed under the License is distributed on an | |
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| # KIND, either express or implied. See the License for the | |
| # specific language governing permissions and limitations | |
| # under the License. | |
| name: Spark SQL Tests | |
| concurrency: | |
| group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} | |
| cancel-in-progress: true | |
| on: | |
| push: | |
| paths-ignore: | |
| - "doc/**" | |
| - "docs/**" | |
| - "**.md" | |
| pull_request: | |
| paths-ignore: | |
| - "doc/**" | |
| - "docs/**" | |
| - "**.md" | |
| # manual trigger | |
| # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow | |
| workflow_dispatch: | |
| inputs: | |
| collect-fallback-logs: | |
| description: 'Whether to collect Comet fallback reasons from spark sql unit test logs' | |
| required: false | |
| default: 'false' | |
| type: boolean | |
| env: | |
| RUST_VERSION: stable | |
| jobs: | |
| spark-sql-auto-scan: | |
| strategy: | |
| matrix: | |
| os: [ubuntu-24.04] | |
| java-version: [11] | |
| spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full: '3.5.7'}] | |
| module: | |
| - {name: "catalyst", args1: "catalyst/test", args2: ""} | |
| - {name: "sql_core-1", args1: "", args2: sql/testOnly * -- -l org.apache.spark.tags.ExtendedSQLTest -l org.apache.spark.tags.SlowSQLTest} | |
| - {name: "sql_core-2", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.ExtendedSQLTest"} | |
| - {name: "sql_core-3", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.SlowSQLTest"} | |
| - {name: "sql_hive-1", args1: "", args2: "hive/testOnly * -- -l org.apache.spark.tags.ExtendedHiveTest -l org.apache.spark.tags.SlowHiveTest"} | |
| - {name: "sql_hive-2", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.ExtendedHiveTest"} | |
| - {name: "sql_hive-3", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.SlowHiveTest"} | |
| fail-fast: false | |
| name: spark-sql-${{ matrix.module.name }}/${{ matrix.os }}/spark-${{ matrix.spark-version.full }}/java-${{ matrix.java-version }} | |
| runs-on: ${{ matrix.os }} | |
| container: | |
| image: amd64/rust | |
| steps: | |
| - uses: actions/checkout@v5 | |
| - name: Setup Rust & Java toolchain | |
| uses: ./.github/actions/setup-builder | |
| with: | |
| rust-version: ${{env.RUST_VERSION}} | |
| jdk-version: ${{ matrix.java-version }} | |
| - name: Setup Spark | |
| uses: ./.github/actions/setup-spark-builder | |
| with: | |
| spark-version: ${{ matrix.spark-version.full }} | |
| spark-short-version: ${{ matrix.spark-version.short }} | |
| - name: Run Spark tests | |
| run: | | |
| cd apache-spark | |
| rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet cache requires cleanups | |
| ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs || 'false' }} \ | |
| build/sbt -Dsbt.log.noformat=true ${{ matrix.module.args1 }} "${{ matrix.module.args2 }}" | |
| if [ "${{ github.event.inputs.collect-fallback-logs }}" = "true" ]; then | |
| find . -type f -name "unit-tests.log" -print0 | xargs -0 grep -h "Comet cannot accelerate" | sed 's/.*Comet cannot accelerate/Comet cannot accelerate/' | sort -u > fallback.log | |
| fi | |
| env: | |
| LC_ALL: "C.UTF-8" | |
| - name: Upload fallback log | |
| if: ${{ github.event.inputs.collect-fallback-logs == 'true' }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: fallback-log-spark-sql-${{ matrix.module.name }}-${{ matrix.os }}-spark-${{ matrix.spark-version.full }}-java-${{ matrix.java-version }} | |
| path: "**/fallback.log" | |
| spark-sql-native-native-comet: | |
| strategy: | |
| matrix: | |
| os: [ ubuntu-24.04 ] | |
| java-version: [ 11 ] | |
| spark-version: [ { short: '3.4', full: '3.4.3' }, { short: '3.5', full: '3.5.7' } ] | |
| module: | |
| - { name: "catalyst", args1: "catalyst/test", args2: "" } | |
| - { name: "sql_core-1", args1: "", args2: sql/testOnly * -- -l org.apache.spark.tags.ExtendedSQLTest -l org.apache.spark.tags.SlowSQLTest } | |
| - { name: "sql_core-2", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.ExtendedSQLTest" } | |
| - { name: "sql_core-3", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.SlowSQLTest" } | |
| - { name: "sql_hive-1", args1: "", args2: "hive/testOnly * -- -l org.apache.spark.tags.ExtendedHiveTest -l org.apache.spark.tags.SlowHiveTest" } | |
| - { name: "sql_hive-2", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.ExtendedHiveTest" } | |
| - { name: "sql_hive-3", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.SlowHiveTest" } | |
| fail-fast: false | |
| name: spark-sql-native-comet-${{ matrix.module.name }}/${{ matrix.os }}/spark-${{ matrix.spark-version.full }}/java-${{ matrix.java-version }} | |
| runs-on: ${{ matrix.os }} | |
| container: | |
| image: amd64/rust | |
| steps: | |
| - uses: actions/checkout@v5 | |
| - name: Setup Rust & Java toolchain | |
| uses: ./.github/actions/setup-builder | |
| with: | |
| rust-version: ${{env.RUST_VERSION}} | |
| jdk-version: ${{ matrix.java-version }} | |
| - name: Setup Spark | |
| uses: ./.github/actions/setup-spark-builder | |
| with: | |
| spark-version: ${{ matrix.spark-version.full }} | |
| spark-short-version: ${{ matrix.spark-version.short }} | |
| - name: Run Spark tests | |
| run: | | |
| cd apache-spark | |
| rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet cache requires cleanups | |
| ENABLE_COMET=true ENABLE_COMET_ONHEAP=true COMET_PARQUET_SCAN_IMPL=native_comet ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs || 'false' }} \ | |
| build/sbt -Dsbt.log.noformat=true ${{ matrix.module.args1 }} "${{ matrix.module.args2 }}" | |
| if [ "${{ github.event.inputs.collect-fallback-logs }}" = "true" ]; then | |
| find . -type f -name "unit-tests.log" -print0 | xargs -0 grep -h "Comet cannot accelerate" | sed 's/.*Comet cannot accelerate/Comet cannot accelerate/' | sort -u > fallback.log | |
| fi | |
| env: | |
| LC_ALL: "C.UTF-8" | |
| - name: Upload fallback log | |
| if: ${{ github.event.inputs.collect-fallback-logs == 'true' }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: fallback-log-spark-sql-native-comet-${{ matrix.module.name }}-${{ matrix.os }}-spark-${{ matrix.spark-version.full }}-java-${{ matrix.java-version }} | |
| path: "**/fallback.log" | |
| spark-sql-native-iceberg-compat: | |
| strategy: | |
| matrix: | |
| os: [ubuntu-24.04] | |
| java-version: [11] | |
| spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full: '3.5.7'}] | |
| module: | |
| - {name: "catalyst", args1: "catalyst/test", args2: ""} | |
| - {name: "sql_core-1", args1: "", args2: sql/testOnly * -- -l org.apache.spark.tags.ExtendedSQLTest -l org.apache.spark.tags.SlowSQLTest} | |
| - {name: "sql_core-2", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.ExtendedSQLTest"} | |
| - {name: "sql_core-3", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.SlowSQLTest"} | |
| - {name: "sql_hive-1", args1: "", args2: "hive/testOnly * -- -l org.apache.spark.tags.ExtendedHiveTest -l org.apache.spark.tags.SlowHiveTest"} | |
| - {name: "sql_hive-2", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.ExtendedHiveTest"} | |
| - {name: "sql_hive-3", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.SlowHiveTest"} | |
| fail-fast: false | |
| name: spark-sql-iceberg-compat-${{ matrix.module.name }}/${{ matrix.os }}/spark-${{ matrix.spark-version.full }}/java-${{ matrix.java-version }} | |
| runs-on: ${{ matrix.os }} | |
| container: | |
| image: amd64/rust | |
| steps: | |
| - uses: actions/checkout@v5 | |
| - name: Setup Rust & Java toolchain | |
| uses: ./.github/actions/setup-builder | |
| with: | |
| rust-version: ${{env.RUST_VERSION}} | |
| jdk-version: ${{ matrix.java-version }} | |
| - name: Setup Spark | |
| uses: ./.github/actions/setup-spark-builder | |
| with: | |
| spark-version: ${{ matrix.spark-version.full }} | |
| spark-short-version: ${{ matrix.spark-version.short }} | |
| - name: Run Spark tests | |
| run: | | |
| cd apache-spark | |
| rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet cache requires cleanups | |
| ENABLE_COMET=true ENABLE_COMET_ONHEAP=true COMET_PARQUET_SCAN_IMPL=native_iceberg_compat ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs || 'false' }} \ | |
| build/sbt -Dsbt.log.noformat=true ${{ matrix.module.args1 }} "${{ matrix.module.args2 }}" | |
| if [ "${{ github.event.inputs.collect-fallback-logs }}" = "true" ]; then | |
| find . -type f -name "unit-tests.log" -print0 | xargs -0 grep -h "Comet cannot accelerate" | sed 's/.*Comet cannot accelerate/Comet cannot accelerate/' | sort -u > fallback.log | |
| fi | |
| env: | |
| LC_ALL: "C.UTF-8" | |
| - name: Upload fallback log | |
| if: ${{ github.event.inputs.collect-fallback-logs == 'true' }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: fallback-log-spark-sql-iceberg-compat-${{ matrix.module.name }}-${{ matrix.os }}-spark-${{ matrix.spark-version.full }}-java-${{ matrix.java-version }} | |
| path: "**/fallback.log" | |
| merge-fallback-logs: | |
| if: ${{ github.event.inputs.collect-fallback-logs == 'true' }} | |
| name: merge-fallback-logs | |
| needs: [ spark-sql-auto-scan, spark-sql-native-native-comet, spark-sql-native-iceberg-compat ] | |
| runs-on: ubuntu-24.04 | |
| steps: | |
| - name: Download fallback log artifacts | |
| uses: actions/download-artifact@v5 | |
| with: | |
| path: fallback-logs/ | |
| - name: Merge fallback logs | |
| run: | | |
| find ./fallback-logs/ -type f -name "fallback.log" -print0 | xargs -0 cat | sort -u > all_fallback.log | |
| - name: Upload merged fallback log | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: all-fallback-log | |
| path: all_fallback.log |