Add EnumValueSimple Trait to reduce EnumValue complexity - #1707
Merged
Conversation
olabusayoT
changed the title
EnumValueSimple Trait tp reduce EnumValue complexityEnumValueSimple Trait to reduce EnumValue complexity
stevedlawrence
approved these changes
Aug 21, 2026
| @@ -120,18 +120,15 @@ trait EnumValue extends EnumValueBase { | |||
| override lazy val toString = { | |||
Member
There was a problem hiding this comment.
Note, there's a typo in bug number in the commit, it should be DAFFODIL-2983 instead of 2963
| } | ||
|
|
||
| trait EnumValueSimple extends EnumValueBase { | ||
| override def toString = getNameFromClass(this) |
Member
There was a problem hiding this comment.
Suggest we make this a override lazy val to match EnumValue.
| } | ||
| } | ||
|
|
||
| trait EnumValueSimple extends EnumValueBase { |
Member
There was a problem hiding this comment.
I don't love the name Simple since it doesn't really convey much. Thoughts on EnumValueUpperCamel with the understanding that EnumValue is the normal camel case for the vast majority of properties? No strong preference though if that feels too verbose/specific.
Contributor
Author
There was a problem hiding this comment.
Throught on Literal instead? EnumValueLiteral since it's the untransformed version
olabusayoT
force-pushed
the
daf-2983-enumvaluesimple
branch
from
August 25, 2026 17:18
dcb1087 to
718f531
Compare
- add handling exceptions/special cases like CalendarFirstDayOfWeek in property generation instead DAFFODIL-2983
olabusayoT
force-pushed
the
daf-2983-enumvaluesimple
branch
from
September 8, 2026 18:26
718f531 to
d83d56e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAFFODIL-2983