-
Couldn't load subscription status.
- Fork 490
feat(browser): Work on browser (CB-12024) #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dudeofawesome
wants to merge
11
commits into
apache:master
Choose a base branch
from
dudeofawesome:CB-12024cordova-plugin-statusbar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e312add
Initial work to support browser platform
dudeofawesome 78bafac
Changing StyleLightContent color
dudeofawesome a81826c
Adding partial support for more browsers
dudeofawesome 7b0f75b
Adding partial support for iOS Safari
dudeofawesome 791f666
Adding Browser platform to README
dudeofawesome 3274fc1
Fixed a typo
dudeofawesome da99feb
Fixing a couple typos
dudeofawesome 2a3014e
CB-12024 browser: Adding more detail to README
dudeofawesome e09ada0
Merge remote-tracking branch 'apache/master' into CB-12024cordova-plu…
dudeofawesome ffd3d6c
Merge branch 'master' into CB-12024cordova-plugin-statusbar
dudeofawesome 8baaf38
Merge branch 'master' into CB-12024cordova-plugin-statusbar
dudeofawesome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| "id": "cordova-plugin-statusbar", | ||
| "platforms": [ | ||
| "android", | ||
| "browser", | ||
| "ios", | ||
| "wp7", | ||
| "wp8", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "some browser chrome" exactly mean here?
"browser window on some (mobile OS system) browsers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It varies by browser support of course, but it typically means the tab color and the navigation bar color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can extend the explanation of the affected browser chrome, but I think that is better handled by the caniuse page.