Skip to content

fix(ios): propery styling of address label#1129

Open
GitToTheHub wants to merge 1 commit intomasterfrom
pr-ios-style-address-label
Open

fix(ios): propery styling of address label#1129
GitToTheHub wants to merge 1 commit intomasterfrom
pr-ios-style-address-label

Conversation

@GitToTheHub
Copy link
Contributor

  • Add background view for address label, so the address label can have paddings when a background is set
  • Add semi-transparent background with round corners
  • Add margins to the address background

Generated-By: GPT-5, XCode 26

Before  After
image  image

The green color shines through the transparent parts of the in-app browser.

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Add background view for address label, so the address label can have paddings when a background is set
- Add semi-transparent background with round corners
- Add margins to the address background

Generated-By: GPT-5, XCode 26
GitToTheHub added a commit that referenced this pull request Mar 1, 2026
- Overlay Toolbar and Address Bar over the WebView, so more web content can be shown and no background must be set for the Toolbar
- Insets are set for the WebView to to take the Toolbar and Address Bar into account, so the content can always be scrolled in a visible area
- Depends on #1128 and #1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant