Skip to content

fix(ios): topbar liquid glass #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johann9898 wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix(ios): topbar liquid glass #1097

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1128cb6
Topbar - Fix liquid glass problem
johann9898 Dec 19, 2025
f8b27fc
fix rest
johann9898 Dec 19, 2025
85f330d
Merge pull request #1 from landsbankinn/topbar-fix
johann9898 Dec 19, 2025
1420960
Added blur and better check
johann9898 Dec 20, 2025
3b8cc6e
remove background color in the wrong place
johann9898 Dec 20, 2025
9551c08
Merge pull request #2 from landsbankinn/topbar-fix
johann9898 Dec 20, 2025
c648ec2
Topbar - Fix liquid glass problem
johann9898 Dec 19, 2025
204de85
Fix merge conflict
johann9898 Jan 29, 2026
f53e35f
Merge branch 'master' of https://github.com/landsbankinn/cordova-plug…
johann9898 Jan 29, 2026
104f186
Fix merge conflict
johann9898 Jan 29, 2026
b6ba3b2
Merge branch 'master' of https://github.com/apache/cordova-plugin-ina…
johann9898 Feb 2, 2026
ddd1367
bottom translucent work with safe area
johann9898 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/ios/CDVWKInAppBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,11 @@ - (void)createViews

self.closeButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(close)];
self.closeButton.enabled = YES;

// Fixes the Liquid Glass issue on iOS version >= 26 where the buttons have a translucent background
if (@available(iOS 26.0, *)) {
Copy link
Contributor

@breautek breautek Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe these checks are sufficient as it assumes that the environment is running at least XCode 26 and Cordova iOS framework declares support for XCode 15 and later.

There is a way to do a preprocessor check that is more resilient to the XCode environment, I just don't recall the exact syntax for that.

Copy link
Member

@erisu erisu Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preprocessor check might be this, but I don’t remember exactly.

#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 260000
    if (@available(iOS 26.0, *)) {
        self.closeButton.hidesSharedBackground = YES;
    }
#endif

Copy link
Author

@johann9898 johann9898 Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i will add the preprocessor check too

self.closeButton.hidesSharedBackground = YES;
}

UIBarButtonItem* flexibleSpaceButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil action:nil];

Expand All @@ -791,6 +796,11 @@ - (void)createViews
}
if (!_browserOptions.toolbartranslucent) { // Set toolbar translucent to no if user sets it in options
self.toolbar.translucent = NO;

// Fixes the Liquid Glass issue on iOS version >= 26 where the top bar becomes transparent
if (@available(iOS 26.0, *)) {
self.toolbar.backgroundColor = [self colorFromHexString:_browserOptions.toolbarcolor];
}
}

CGFloat labelInset = 5.0;
Expand Down Expand Up @@ -833,6 +843,11 @@ - (void)createViews
self.forwardButton.tintColor = [self colorFromHexString:_browserOptions.navigationbuttoncolor];
}

// Fixes the Liquid Glass issue on iOS version >= 26 where the buttons have a translucent background
if (@available(iOS 26.0, *)) {
self.forwardButton.hidesSharedBackground = YES;
}

NSString* backArrowString = NSLocalizedString(@"◄", nil); // create arrow from Unicode char
self.backButton = [[UIBarButtonItem alloc] initWithTitle:backArrowString style:UIBarButtonItemStylePlain target:self action:@selector(goBack:)];
self.backButton.enabled = YES;
Expand All @@ -841,6 +856,11 @@ - (void)createViews
self.backButton.tintColor = [self colorFromHexString:_browserOptions.navigationbuttoncolor];
}

// Fixes the Liquid Glass issue on iOS version >= 26 where the buttons have a translucent background
if (@available(iOS 26.0, *)) {
self.backButton.hidesSharedBackground = YES;
}

// Filter out Navigation Buttons if user requests so
if (_browserOptions.hidenavigationbuttons) {
if (_browserOptions.lefttoright) {
Expand Down Expand Up @@ -881,6 +901,11 @@ - (void)setCloseButtonTitle:(NSString*)title : (NSString*) colorString : (int) b
// If color on closebutton is requested then initialize with that that color, otherwise use initialize with default
self.closeButton.tintColor = colorString != nil ? [self colorFromHexString:colorString] : [UIColor colorWithRed:60.0 / 255.0 green:136.0 / 255.0 blue:230.0 / 255.0 alpha:1];

// Fixes the Liquid Glass issue on iOS version >= 26 where the buttons have a translucent background
if (@available(iOS 26.0, *)) {
self.closeButton.hidesSharedBackground = YES;
}

NSMutableArray* items = [self.toolbar.items mutableCopy];
[items replaceObjectAtIndex:buttonIndex withObject:self.closeButton];
[self.toolbar setItems:items];
Expand Down
Loading