Skip to content

chore: Fix improperly ignored deprecation warning#1635

Merged
dpogue merged 1 commit intoapache:masterfrom
dpogue:warning-fix
Mar 12, 2026
Merged

chore: Fix improperly ignored deprecation warning#1635
dpogue merged 1 commit intoapache:masterfrom
dpogue:warning-fix

Conversation

@dpogue
Copy link
Member

@dpogue dpogue commented Mar 12, 2026

Platforms affected

iOS

Motivation and Context

Follow-up from #1632

Description

We need to ignore the warning about implementing a deprecated method, not about using a deprecated declaration.

Testing

Confirm that no deprecation warning is printed when running tests.

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 8.1.0 milestone Mar 12, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (50fc78c) to head (1096d68).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files          18       18           
  Lines        5312     5312           
=======================================
  Hits         4261     4261           
  Misses       1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpogue dpogue marked this pull request as ready for review March 12, 2026 08:00
@dpogue dpogue requested a review from erisu March 12, 2026 08:01
@dpogue dpogue merged commit 49a97b3 into apache:master Mar 12, 2026
12 checks passed
@dpogue dpogue deleted the warning-fix branch March 12, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants