CASSGO-38 Marshal error messages enhancement #1838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
force-pushed
the
marshal-errors-enhancement
branch
from
bb0dab6 to
c3dcd98
Compare
worryg0d
reviewed
Oct 31, 2024
marshal.go
Outdated
| @@ -333,7 +333,7 @@ func marshalVarchar(info TypeInfo, value interface{}) ([]byte, error) { | |||
| case k == reflect.Slice && t.Elem().Kind() == reflect.Uint8: | |||
| return rv.Bytes(), nil | |||
| } | |||
| return nil, marshalErrorf("can not marshal %T into %s", value, info) | |||
| return nil, marshalErrorf("can not marshal %T into %s. Accepted types: Marshaler, string, []byte, unsetColumn.", value, info) | |||
There was a problem hiding this comment.
unsetColumn is not an exported type, so the driver doesn't have to expose it to the user. There is a UnsetValue global var of type unsetColumn which is meant to be used to ignore writing. You can find it here.
There was a problem hiding this comment.
Thank you, refactored
There was a problem hiding this comment.
I meant to change unsetColumn to UnsetValue, not to delete it at all
marshal.go
Outdated
| @@ -2280,7 +2280,7 @@ func marshalUDT(info TypeInfo, value interface{}) ([]byte, error) { | |||
| } | |||
|
|
|||
| if k.Kind() != reflect.Struct || !k.IsValid() { | |||
| return nil, marshalErrorf("cannot marshal %T into %s", value, info) | |||
| return nil, marshalErrorf("cannot marshal %T into %s. Accepted types: Marshaler, unsetColumn, UDTMarshaler, UDTMarshaler, map[string]interface{}, struct.", value, info) | |||
tengu-alt
force-pushed
the
marshal-errors-enhancement
branch
3 times, most recently
from
f4a0127 to
dbec58a
Compare
tengu-alt
force-pushed
the
marshal-errors-enhancement
branch
from
dbec58a to
d6550c9
Compare
joao-r-reis
reviewed
Nov 22, 2024
marshal.go
Outdated
| @@ -2208,7 +2210,7 @@ func unmarshalTuple(info TypeInfo, data []byte, value interface{}) error { | |||
| return nil | |||
| } | |||
|
|
|||
| return unmarshalErrorf("cannot unmarshal %s into %T", info, value) | |||
| return unmarshalErrorf("cannot unmarshal %s into %T. Accepted types: struct, []interface{}, array, slice.", info, value) | |||
There was a problem hiding this comment.
Unmarshaler is also accepted I think. Also the accepted types other than []interface{} have to be a pointer if I'm reading the code correctly (so *struct, *array, *slice)
There was a problem hiding this comment.
Good catch! Thank you.
marshal.go
Outdated
| @@ -1706,7 +1708,7 @@ func unmarshalList(info TypeInfo, data []byte, value interface{}) error { | |||
| } | |||
| return nil | |||
| } | |||
| return unmarshalErrorf("can not unmarshal %s into %T", info, value) | |||
| return unmarshalErrorf("can not unmarshal %s into %T. Accepted types: slice, array.", info, value) | |||
There was a problem hiding this comment.
I think it has to be *slice, *array
marshal.go
Outdated
| @@ -2392,7 +2394,7 @@ func unmarshalUDT(info TypeInfo, data []byte, value interface{}) error { | |||
| } | |||
| k := rv.Elem() | |||
| if k.Kind() != reflect.Struct || !k.IsValid() { | |||
| return unmarshalErrorf("cannot unmarshal %s into %T", info, value) | |||
| return unmarshalErrorf("cannot unmarshal %s into %T. Accepted types: Unmarshaler, UDTUnmarshaler, *map[string]interface{}, struct.", info, value) | |||
joao-r-reis
changed the title
tengu-alt
force-pushed
the
marshal-errors-enhancement
branch
from
d6550c9 to
74254c8
Compare
joao-r-reis
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides marshal/unmarshal error messages enhancement.
According to #671 errors were updated by the supported types list.