Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21907: Backport of set OAuth2 scope on request body to Camel 4.10.x #17631

Merged

Conversation

LeandroPachis
Copy link
Contributor

@LeandroPachis LeandroPachis commented Apr 1, 2025

Description

Backport for CAMEL-21907 to Camel 4.10.x

Updated OAuth2ClientConfigurer to set the parameter values for oauth2Scope on the request body instead of a query parameter when using client_credentials as grant_type. This should be done according to OAuth2 documentation provided by Microsoft.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor

oscerd commented Apr 1, 2025

Can you please rebase?

@LeandroPachis LeandroPachis force-pushed the CAMEL-21907-4.10.x-backport branch from e4030f3 to 806c77c Compare April 2, 2025 06:09
@LeandroPachis
Copy link
Contributor Author

@oscerd done

@LeandroPachis LeandroPachis force-pushed the CAMEL-21907-4.10.x-backport branch from 806c77c to ea29247 Compare April 2, 2025 09:08
- Updated OAuth2ClientConfigurer to set the parameter values for oauth2Scope on the request body instead of a query parameter when using client_credentials as grant_type. This should be done according to OAuth2 documentation provided by Microsoft.
@LeandroPachis LeandroPachis force-pushed the CAMEL-21907-4.10.x-backport branch from ea29247 to 5fa9512 Compare April 2, 2025 09:55
@oscerd oscerd merged commit e0b8bb7 into apache:camel-4.10.x Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants