Add Datadog IO #37319
Add Datadog IO #37319
Conversation
derrickaw
force-pushed
the
addDatadogIO
branch
from
b74daae to
b2ed9dd
Compare
|
Run Java_GCP_IO_Direct PreCommit |
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Thanks, left a few comments
| implementation library.java.google_http_client | ||
| implementation library.java.google_code_gson | ||
| implementation library.java.auto_value_annotations | ||
| annotationProcessor library.java.auto_value |
There was a problem hiding this comment.
This should already be handled by BeamModulePlugin:
and not needed here
| activemq_mqtt : "org.apache.activemq:activemq-mqtt:$activemq_version", | ||
| args4j : "args4j:args4j:2.33", | ||
| auto_value_annotations : "com.google.auto.value:auto-value-annotations:$autovalue_version", | ||
| auto_value : "com.google.auto.value:auto-value:$autovalue_version", |
There was a problem hiding this comment.
see below, this isn't needed
| import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| import com.google.auto.value.AutoValue; | ||
| import javax.annotation.Nullable; |
There was a problem hiding this comment.
Prefer to use checkframework Nullable
| include(":sdks:java:io:bigquery-io-perf-tests") | ||
| include(":sdks:java:io:cdap") | ||
| include(":sdks:java:io:csv") | ||
| include(":sdks:java:io:datadog") |
There was a problem hiding this comment.
in addition to this, please add it to test:
Line 341 in 82ebcb2
and also please setup a PreCommit and add it in https://github.com/apache/beam/blob/master/.github/workflows/README.md#precommit-jobs
we can copy paste from an existing precommit workflow like https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_Java_Clickhouse_IO_Direct.yml
2 participants
Addresses #37318
Ported from here and here.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.