Skip to content

Conversation

@derrickaw
Copy link
Collaborator

  1. Investigation work for [Feature Request]: YAML - how to output the error of error_handling in sub yaml? #37080.
  2. Add more tests to cover this scenario of having a Provider that has error handling.
  3. Provide website example of provider with error handling.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of error handling within Apache Beam's YAML transforms. It introduces comprehensive test coverage for scenarios involving multiple transforms generating errors and specifically addresses error handling within custom YAML providers. Furthermore, it provides clear documentation and examples for users to effectively define and consume error outputs from their custom YAML transforms, ensuring better pipeline stability and error visibility.

Highlights

  • Enhanced Error Handling Tests: New test cases have been added to validate error handling scenarios, including combining errors from multiple transforms and ensuring proper error output consumption.
  • Custom YAML Provider Error Handling: Introduced dedicated tests for custom YAML providers to ensure they correctly expose and manage error outputs, including scenarios where error outputs must be consumed.
  • Documentation for Custom Providers: Updated the documentation to include a new section on how to implement and consume error handling within custom YAML transforms, complete with practical examples.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw changed the title [yaml] : add more error handling and provider tests [yaml] : add more error handling and provider tests and website example Jan 7, 2026
@derrickaw derrickaw changed the title [yaml] : add more error handling and provider tests and website example [yaml] : add more error handling tests and website example Jan 7, 2026
@derrickaw
Copy link
Collaborator Author

Run Python_Coverage PreCommit 3.10

@derrickaw
Copy link
Collaborator Author

Run Python PreCommit 3.12

@derrickaw
Copy link
Collaborator Author

Run Python PreCommit 3.13

1 similar comment
@derrickaw
Copy link
Collaborator Author

Run Python PreCommit 3.13

@derrickaw
Copy link
Collaborator Author

Failures don't seem related.

@derrickaw
Copy link
Collaborator Author

Run Python PreCommit 3.13

@derrickaw derrickaw marked this pull request as ready for review January 7, 2026 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Assigning reviewers:

R: @damccorm for label python.
R: @Abacn for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit d7fa511 into apache:master Jan 8, 2026
109 of 113 checks passed
@derrickaw derrickaw deleted the addProviderSubTest branch January 8, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants