Skip to content

Remove temporary KafkaSourceDescriptor.create function #36357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HurSungYun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove temporary KafkaSourceDescriptor.create function #36357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaSourceDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import java.util.List;
import org.apache.beam.sdk.schemas.AutoValueSchema;
import org.apache.beam.sdk.schemas.annotations.DefaultSchema;
import org.apache.beam.sdk.schemas.annotations.SchemaCreate;
import org.apache.beam.sdk.schemas.annotations.SchemaFieldName;
import org.apache.beam.sdk.schemas.annotations.SchemaIgnore;
import org.apache.kafka.common.TopicPartition;
Expand Down Expand Up @@ -106,26 +105,4 @@ private static void checkArguments(
stopReadOffset == null || stopReadTime == null,
"stopReadOffset and stopReadTime are optional but mutually exclusive. Please set only one of them.");
}

@SchemaCreate
@SuppressWarnings("all")
// TODO(BEAM-10677): Remove this function after AutoValueSchema is fixed.
static KafkaSourceDescriptor create(
String topic,
Integer partition,
Long start_read_offset,
Instant start_read_time,
Long stop_read_offset,
Instant stop_read_time,
List<String> bootstrap_servers) {
checkArguments(start_read_offset, start_read_time, stop_read_offset, stop_read_time);
return new AutoValue_KafkaSourceDescriptor(
topic,
partition,
start_read_offset,
start_read_time,
stop_read_offset,
stop_read_time,
bootstrap_servers);
}
}
Loading