Fix PostCommit Python Arm job #35962
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the juliaset_test_it.py example to ensure compatibility with Python 3.12. It addresses the removal of the distutils module in Python 3.12 by conditionally including the setup_file argument only for Python versions prior to 3.12, preventing errors when running tests on newer Python environments.
Highlights
- Python 3.12 Compatibility: Ensures the juliaset example test runs successfully on Python 3.12 by adapting to the removal of distutils.
- Conditional setup_file Argument: The setup_file argument is now conditionally added to the pipeline options, only when the Python version is less than 3.12.
- System Module Import: The sys module is imported to check the Python version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Amar3tto
changed the title
| # distutils was removed from Python 3.12 | ||
| if sys.version_info < (3, 12): | ||
| extra_args['setup_file'] = os.path.normpath( | ||
| os.path.join(os.path.dirname(__file__), '..', 'setup.py')) |
There was a problem hiding this comment.
This is meant to be part of the example -
- but in general, it is a better idea to just use a requirements.txt file for use cases like this now.Could we update the example (both here and what I linked) to use a requirements.txt file with the corresponding pipeline option? The only thing we'd need to pull out is numpy like we do here
Then we could remove setup.py from the example
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Amar3tto
force-pushed
the
fix-python-arm-postcommit
branch
from
d47ee87 to
8da0802
Compare
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks - I see https://github.com/apache/beam/actions/runs/17270425587 so this LGTM
|
I don't follow this change. --setup_file is an option some people use to package a multi-file pipleine in a package and install that on the worker. The integration tests we had was exercising this pipeline option. We can use such test for #37331 why was this test failing on ARM? |
|
IIRC, the old test relied on distutils which was removed in Python 3.12, so I think the example needed to change, and that's why we were seeing failures. In retrospect, I think the way we did it/I recommended was a mistake. Originally, I saw we were just using the setup file to install dependencies, which was an odd usage, but I now see that we're explicit about this being to demonstrate a custom command. I also didn't realize it was our only setup_file coverage. I think we should mostly back out this change and update to just not use distutils instead |
|
Ack, thanks and no worries, it happens!
with custom containers, custom commands in setup.py are not a common use-case anymore. people still use --setup_file for submitting pipeline as a package. that's the main value of this option. |
3 participants
Fixes #30760
Successful run: https://github.com/apache/beam/actions/runs/17270425587
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.