-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[IcebergIO] load tests #33728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ahmedabu98
wants to merge
9
commits into
apache:master
Choose a base branch
from
ahmedabu98:iceberg_perf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[IcebergIO] load tests #33728
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d55f678
add it/iceberg and BQMS stress test
ahmedabu98 e894a86
cleanup gradle file
ahmedabu98 f1c5d8b
Merge branch 'master' of https://github.com/ahmedabu98/beam into iceb…
ahmedabu98 29df67a
Merge branch 'master' of https://github.com/ahmedabu98/beam into iceb…
ahmedabu98 d260969
update
ahmedabu98 48b64c4
update
ahmedabu98 b9fc380
deps
ahmedabu98 e2459e4
testing
ahmedabu98 cc7dd7d
testing rename
ahmedabu98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "comment": "Modify this file in a trivial way to cause this test suite to run", | ||
| "modification": 1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * License); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an AS IS BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import org.apache.beam.gradle.IoPerformanceTestUtilities | ||
|
|
||
| plugins { id 'org.apache.beam.module' } | ||
| applyJavaNature( | ||
| automaticModuleName: 'org.apache.beam.it.iceberg', | ||
| exportJavadoc: false, | ||
| ) | ||
|
|
||
| description = "Apache Beam :: IT :: Iceberg" | ||
| ext.summary = "Integration test utilities for Iceberg." | ||
|
|
||
| dependencies { | ||
| testImplementation project(path: ":it:common") | ||
| testImplementation project(path: ":it:google-cloud-platform") | ||
| testImplementation project(path: ":sdks:java:io:synthetic") | ||
| testImplementation project(path: ":sdks:java:managed") | ||
| testImplementation library.java.google_api_services_bigquery | ||
|
|
||
| testImplementation project(path: ":sdks:java:io:iceberg") | ||
| testImplementation "org.apache.iceberg:iceberg-core:1.6.1" | ||
| testImplementation library.java.hadoop_common | ||
| testRuntimeOnly project(path: ":sdks:java:io:iceberg:bqms", configuration: "shadow") | ||
| testRuntimeOnly library.java.hadoop_auth | ||
| testRuntimeOnly library.java.hadoop_client | ||
| testRuntimeOnly library.java.bigdataoss_gcs_connector | ||
|
|
||
| testImplementation project(path: ":runners:direct-java") | ||
| testImplementation project(path: ":runners:google-cloud-dataflow-java") | ||
| testImplementation project(path: ":sdks:java:testing:test-utils") | ||
| testImplementation project(path: ":sdks:java:extensions:google-cloud-platform-core", configuration: "testRuntimeMigration") | ||
| testImplementation project(":sdks:java:io:google-cloud-platform") | ||
| testImplementation library.java.google_api_services_dataflow | ||
| } | ||
|
|
||
| tasks.register( | ||
| "IcebergBQMSLoadTestMedium", IoPerformanceTestUtilities.IoPerformanceTest, project, 'iceberg', 'IcebergIOBigQueryMetastoreST', | ||
| ['configuration':'medium','project':'apache-beam-testing', 'artifactBucket':'io-performance-temp'] | ||
| + System.properties | ||
| ) | ||
|
|
||
| tasks.register( | ||
| "IcebergBQMSLoadTestLarge", IoPerformanceTestUtilities.IoPerformanceTest, project, 'iceberg', 'IcebergIOBigQueryMetastoreST', | ||
| ['configuration':'large','project':'apache-beam-testing', 'artifactBucket':'io-performance-temp'] | ||
| + System.properties | ||
| ) | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you trying to accomplish here? One side effect of this change is that now 2 different load tests will send different volumes of messages (e.g. if I'm slow processing messages, I'll get extra messages because more of them will have late timestamps).
I'm not super familiar with this code, so possible I'm misunderstanding the previous behavior, but growing load like this seems like it could be suboptimal