Skip to content

Warn when DoFn.process uses both yield and return #25743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 14 commits into from
Mar 21, 2023
Merged

Warn when DoFn.process uses both yield and return #25743

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a870b02
Raise the Runtime error when DoFn.process uses both yield and return
liferoad Mar 7, 2023
e42a63d
skip the inner functions when checking return and yield
liferoad Mar 7, 2023
997a8e6
skip builtin function types
liferoad Mar 8, 2023
6712440
Capture TypeError
liferoad Mar 8, 2023
e9b9a5d
fix the isort error
liferoad Mar 8, 2023
9652a80
update CHANGES.md for this potential breaking changes
liferoad Mar 9, 2023
d32e368
use the loggin warning rather than raise RuntimeError
liferoad Mar 10, 2023
fe5535f
use the yapf 0.29.0
liferoad Mar 10, 2023
6dcb7a8
format fix
liferoad Mar 11, 2023
8ae2c5d
fix isort
liferoad Mar 11, 2023
53ff0da
Fix the false postive cases
liferoad Mar 14, 2023
e0f82b0
Merge branch 'master' into issue-22969
liferoad Mar 17, 2023
3c84ca0
capture all exceptions
liferoad Mar 18, 2023
b979176
Use debug for exceptions
liferoad Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdks/python/apache_beam/transforms/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,8 @@ def _check_fn_use_yield_and_return(fn):
if has_yield and has_return:
return True
return False
except TypeError:
except Exception as e:
_LOGGER.info(str(e))
return False


Expand Down