Skip to content

Conversation

@zertan
Copy link

@zertan zertan commented Dec 17, 2025

This PR implements a "dotted_props:" prefix to filter queries for relaxing JMS property name constraints.

We have implemented something simillar as was already done for "hyphenated_props:".

@zertan zertan changed the title [ARTEMIS-5825] Add a JMS filter constraint relaxation prefix for ... [ARTEMIS-5825] Add a JMS filter constraint relaxation prefix for dotted property names Dec 17, 2025
@tabish121
Copy link
Contributor

There are no tests so it is unclear if this actually works as intended.

@gemmellr
Copy link
Member

gemmellr commented Dec 17, 2025

This would be knocked back for lack of testing currently, but regardless of that another reason might be there is actually an existing option in place that should work for both those cases, try using a (escaped) \"quoted.property.name\" for property names in the selector.

88b7ee3

@jbertram
Copy link
Contributor

FWIW, it looks like the functionality added in 88b7ee3 needs to be documented.

@zertan
Copy link
Author

zertan commented Dec 17, 2025

Okay I was not aware of the escaping part for more complex properties. Tried in python-qpid-proton seemed to not filter correctly with just ". If that works i guess this can be closed. I will try it tomorrow. I can surely add tests if this turns out to be needed later. //Daniel

@gemmellr
Copy link
Member

Just to be clear I only noted the escaping on expectation you were actually using JMS and so would be using a Java string, per the linked test. For python you'll have other options I guess. Its just the bare " around the property name that should be needed in the actual selector string transmitted, since thats not normally present in that location for selectors (and also since string literal values use single quotes which helps to discern the names vs values)

@zertan
Copy link
Author

zertan commented Dec 18, 2025

I have tried with the double quoting and it works. I see it is also documented now great, so I will close this one. Thank you 👍

@zertan zertan closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants