ARTEMIS-5786 determine if address is blocked via mngmnt API #6109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
reviewed
Dec 9, 2025
| ActiveMQServerControl serverControl = createManagementControl(); | ||
| AddressSettings addressSettings = new AddressSettings(); | ||
| addressSettings.setDeadLetterAddress(SimpleString.of("DLA")); | ||
| System.out.println(addressSettings.toJSON()); |
Contributor
There was a problem hiding this comment.
Was this println left in by mistake?
jbertram
force-pushed
the
ARTEMIS-5786
branch
from
601e741 to
67f9d8d
Compare
tabish121
reviewed
Dec 9, 2025
| assertEquals(exactPercentBeforeRestart, addressControl.getAddressLimitPercent()); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
This test failed when I ran the PR through CI
java.lang.Exception: AMQ229069: no operation unBlock/0
at org.apache.activemq.artemis.tests.integration.management.CoreMessagingProxy.invokeOperation(CoreMessagingProxy.java:82)
at org.apache.activemq.artemis.tests.integration.management.CoreMessagingProxy.invokeOperation(CoreMessagingProxy.java:66)
at org.apache.activemq.artemis.tests.integration.management.AddressControlUsingCoreTest$1.unblock(AddressControlUsingCoreTest.java:131)
at org.apache.activemq.artemis.tests.integration.management.AddressControlTest.testIsBlockedViaManagement(AddressControlTest.java:895)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Contributor
Author
There was a problem hiding this comment.
Apparently nothing was actually running org.apache.activemq.artemis.tests.integration.management.AddressControlUsingCoreTest$1.unblock() and it was choking due to a capitalization issue. I've fixed it now.
jbertram
force-pushed
the
ARTEMIS-5786
branch
from
67f9d8d to
4b1e900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.