Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions cpp/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,7 @@
]
},
"grpc",
{
"name": "gtest",
"features": [
"cxx17"
]
},
Comment on lines -45 to -49

@raulcd raulcd Jan 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary anymore since:
microsoft/vcpkg@b00ff11

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should we add cxx20?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this was removed. There's no additional features on vcpkg anymore. You can see that on the commit above. This is how the current port file looks (no features):
https://github.com/microsoft/vcpkg/blob/master/ports/gtest/vcpkg.json

"gtest",
"lz4",
"openssl",
"orc",
Expand All @@ -62,5 +57,5 @@
"zstd"
],
"$comment": "We can update builtin-baseline by 'vcpkg x-update-baseline'",
"builtin-baseline": "09f6a4ef2f08252f7f4d924fd9c2d42165fb21c9"
"builtin-baseline": "40c89449f0ccce12d21f8a906639f6c2c649b9e7"
}
Loading