GH-46623: [C++][Compute] Fix the failure of large memory test in arrow-compute-row-test #46635
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the CI won't tell us anything (the large memory tests are not ran by default). Feel free to try in your local @pitrou . Thanks. |
Yes. For the record, I've opened #46600 for it (and this is how I found out that this test was failing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In #45336 we refined the row table buffer accessors and enforced the validation on who can call the
var_length_rows()method. However a legacy testCompareColumnsToRowsOver4GBFixedLengthis leveraging this accessor to assert this buffer being null.What changes are included in this PR?
We can just check if the row table is fixed length.
Are these changes tested?
Yes.
Are there any user-facing changes?
None.